After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671595 - ephy-sqlite-statement: make properties readable
ephy-sqlite-statement: make properties readable
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-07 20:17 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-07-31 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy-sqlite-statement: make properties readable (2.08 KB, patch)
2012-03-07 20:17 UTC, Diego Escalante Urrelo (not reading bugmail) 		rejected Details | Review
ephy-sqlite-statement: remove get_property cases (1.20 KB, patch)
2012-03-31 02:05 UTC, Diego Escalante Urrelo (not reading bugmail) 		reviewed Details | Review
ephy-sqlite-statement: remove get_property (1.76 KB, patch)
2012-07-31 15:00 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-03-07 20:17:24 UTC 
the getter considers them, so I guess it was a typo.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-03-07 20:17:25 UTC 
Created attachment 209212 [details] [review]
ephy-sqlite-statement: make properties readable

The get_property switch seems to consider them, so I guess it was just a
typo.
Comment 2 Xan Lopez 2012-03-09 13:38:56 UTC 
Review of attachment 209212 [details] [review]:

Just remove the get_property stuff, since it's unused. If we need it we can make them readable again.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-03-31 02:05:17 UTC 
Created attachment 211009 [details] [review]
ephy-sqlite-statement: remove get_property cases

All the properties are write-construct-only.
--

The opposite patch.
Comment 4 Xan Lopez 2012-07-31 14:22:17 UTC 
Review of attachment 211009 [details] [review]:

If they are construct-only you still need to set them (once at construct time). How does this work?
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2012-07-31 14:38:25 UTC 
Back then we agreed to remove them from the switch() because they were not meant to be read:

(In reply to comment #2)
> Review of attachment 209212 [details] [review]:
> 
> Just remove the get_property stuff, since it's unused. If we need it we can
> make them readable again.
Comment 6 Xan Lopez 2012-07-31 14:47:23 UTC 
(In reply to comment #5)
> Back then we agreed to remove them from the switch() because they were not
> meant to be read:
> 

So G_PARAM_WRITABLE and no get_property method at all?
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2012-07-31 15:00:11 UTC 
Created attachment 219988 [details] [review]
ephy-sqlite-statement: remove get_property

All the properties are write-construct-only.
Comment 8 Xan Lopez 2012-07-31 15:04:34 UTC 
Comment on attachment 219988 [details] [review]
ephy-sqlite-statement: remove get_property

Looks good, hopefully it works :]
Comment 9 Diego Escalante Urrelo (not reading bugmail) 2012-07-31 15:09:14 UTC 
Attachment 219988 [details] pushed as 590cedd - ephy-sqlite-statement: remove get_property