After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671509 - Some small UI/theming improvements
Some small UI/theming improvements
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
unspecified
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-03-06 23:58 UTC by Cosimo Cecchi
Modified: 2012-03-18 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
attachment-button: set "linked" style class on the button (1.20 KB, patch)
2012-03-06 23:58 UTC, Cosimo Cecchi
committed Details | Review
table-header: use gtk_widget_create_pango_context() for header buttons (1.73 KB, patch)
2012-03-06 23:58 UTC, Cosimo Cecchi
committed Details | Review
the button with Adwaita and the patch (4.28 KB, image/png)
2012-03-07 00:01 UTC, Cosimo Cecchi
  Details
the header with Adwaita and the patch (9.47 KB, image/png)
2012-03-07 00:01 UTC, Cosimo Cecchi
  Details

Description Cosimo Cecchi 2012-03-06 23:58:29 UTC
See attached patches.
Comment 1 Cosimo Cecchi 2012-03-06 23:58:32 UTC
Created attachment 209121 [details] [review]
attachment-button: set "linked" style class on the button

To get an unified look for themes that support it.
Comment 2 Cosimo Cecchi 2012-03-06 23:58:34 UTC
Created attachment 209122 [details] [review]
table-header: use gtk_widget_create_pango_context() for header buttons

Since we temporarily set custom style classes for the header button on
the table's style context, we cannot rely on the PangoContext used by
gtk_widget_create_pango_layout(), since the font values it will use are
cached by GtkWidget.
By creating a new PangoContext and using that to create our pango
layout, the text we render will correctly support the properties
specified by the theme (such as bold column-header buttons as specified
by Adwaita).
Comment 3 Cosimo Cecchi 2012-03-07 00:01:24 UTC
Created attachment 209123 [details]
the button with Adwaita and the patch
Comment 4 Cosimo Cecchi 2012-03-07 00:01:48 UTC
Created attachment 209124 [details]
the header with Adwaita and the patch
Comment 5 André Klapper 2012-03-07 09:54:35 UTC
With regard to UI Freeze: This comment is an OK from the Evolution user docs maintainer with regard to updating screenshots - still needs OK from maintainers though.
Comment 7 André Klapper 2012-03-18 16:49:37 UTC
Note to myself: Only affected screenshot would be http://git.gnome.org/browse/evolution/plain/help/C/figures/window-overview-layers.png?h=master and I do not consider it relevant enough to break the translated screenshots for 3.4.
Might fix for early 3.5.x though if I feel like.