Bug 671452 - Avoid XMPP accounts to have a negative priority
Avoid XMPP accounts to have a negative priority
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2012-03-06 10:55 UTC by Guillaume Desmottes
Modified: 2012-03-06 15:15 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add magic to automatically run tasks when empathy-auth-client is started (7.19 KB, patch)
2012-03-06 15:04 UTC, Guillaume Desmottes 		committed Details | Diff | Review
sanity-cleaning: fix xmpp accounts having a negative priority (2.52 KB, patch)
2012-03-06 15:04 UTC, Guillaume Desmottes 		committed Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Guillaume Desmottes 2012-03-06 10:55:22 UTC 
Empathy doesn't allow user to set his XMPP priority to a negative value (bug #669712) any more. But that doesn't fix existing account which can experience nasty issues like calls not working (Gabble now refuses to call a contact with a negative priority).

We should clean those accounts the first time empathy 3.4 is started. More generally I think it would be good to have such mechanism in place in Empathy for this kind of cleaning/fixing.
Comment 1 Guillaume Desmottes 2012-03-06 15:04:07 UTC 
Created attachment 209094 [details] [review]
Add magic to automatically run tasks when empathy-auth-client is started

empathy-auth-client is the best place to do such tasks as it will be run even
if using only the Shell without Empathy's UI.
Comment 2 Guillaume Desmottes 2012-03-06 15:04:12 UTC 
Created attachment 209095 [details] [review]
sanity-cleaning: fix xmpp accounts having a negative priority
Comment 3 Guillaume Desmottes 2012-03-06 15:15:33 UTC 
Attachment 209094 [details] pushed as c696253 - Add magic to automatically run tasks when empathy-auth-client is started
Attachment 209095 [details] pushed as 27adcb4 - sanity-cleaning: fix xmpp accounts having a negative priority
Note You need to log in before you can comment on or make changes to this bug.