After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671377 - [Patch] Add keybindings for going to first/next/previous slide
[Patch] Add keybindings for going to first/next/previous slide
Status: RESOLVED WONTFIX
Product: pinpoint
Classification: Other
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Pinpoint maintainer(s)
Pinpoint maintainer(s)
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2012-03-05 15:33 UTC by Vladimír Kincl
Modified: 2018-08-17 19:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This is the diff file with changes. (2.19 KB, patch)
2012-03-05 15:33 UTC, Vladimír Kincl
none Details | Review
whitespace fixes (1.28 KB, patch)
2012-03-17 19:57 UTC, Antonio Terceiro
none Details | Review
skip play/pause logic when there is no speaker screen (717 bytes, patch)
2012-03-17 19:58 UTC, Antonio Terceiro
none Details | Review

Description Vladimír Kincl 2012-03-05 15:33:26 UTC
Created attachment 209005 [details] [review]
This is the diff file with changes.

So basically, this patch allows you to:
Go to back to first slide when ['H','h'] and Home key pressed.
And moving to next/previous slide with left/right click. (Very needed with a presentation remote)
Comment 1 Antonio Terceiro 2012-03-17 19:57:07 UTC
When testing this patch, whenever I use H/h/Home to go to the first slide, I get warnings like this:

(pinpoint:16473): Clutter-CRITICAL **: clutter_text_set_text: assertion `CLUTTER_IS_TEXT (self)' failed

(pinpoint:16473): Clutter-CRITICAL **: clutter_text_set_text: assertion `CLUTTER_IS_TEXT (self)' failed

I am attaching a patch to the fix the whitespace issues I commented on the review and another to silence these warnings.
Comment 2 Antonio Terceiro 2012-03-17 19:57:44 UTC
Created attachment 210012 [details] [review]
whitespace fixes
Comment 3 Antonio Terceiro 2012-03-17 19:58:11 UTC
Created attachment 210013 [details] [review]
skip play/pause logic when there is no speaker screen
Comment 4 Øyvind Kolås (pippin) 2012-03-18 01:47:46 UTC
commit 577ed9bc62b65cf7a16413433cd36d07475ae89f
Refs: 0.1.4-9-g577ed9b
Author:     Vladimír Kincl <kincl.vlada@gmail.com>
AuthorDate: Sat Mar 17 15:20:20 2012 -0300
Commit:     Antonio Terceiro <terceiro@softwarelivre.org>
CommitDate: Sat Mar 17 20:47:38 2012 -0300

    Extra keyboard and mouse bindings

    H/h/Home: first slide, mouse clicks: next/previous

    Signed-off-by: Antonio Terceiro <terceiro@softwarelivre.org>

    https://bugzilla.gnome.org/show_bug.cgi?id=671377


commit ba1e395fb1f95e82b8a45374390cf42403064497
Refs: 0.1.4-11-gba1e395
Author:     Antonio Terceiro <terceiro@softwarelivre.org>
AuthorDate: Sat Mar 17 16:39:41 2012 -0300
Commit:     Antonio Terceiro <terceiro@softwarelivre.org>
CommitDate: Sat Mar 17 20:47:42 2012 -0300

    Skip play/pause logic without a speaker screen
Comment 5 André Klapper 2018-08-17 19:56:50 UTC
pinpoint is not under active development anymore since 2015.
Its codebase has been archived:
https://gitlab.gnome.org/Archive/pinpoint/commits/master

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the
responsibility for active development again.