After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671299 - ximagesink & xvimagesink: replace deprecated XKeycodeToKeysym to XkbKeycodeToKeysym
ximagesink & xvimagesink: replace deprecated XKeycodeToKeysym to XkbKeycodeTo...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.37
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-04 09:15 UTC by Oleksij Rempel
Modified: 2012-03-05 11:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ximagesink patch v1 (2.80 KB, patch)
2012-03-04 09:18 UTC, Oleksij Rempel 		none Details | Review
xvimagesink patch v1 (2.82 KB, patch)
2012-03-04 09:18 UTC, Oleksij Rempel 		none Details | Review
ximagesink patch v2 (2.79 KB, patch)
2012-03-05 10:10 UTC, Oleksij Rempel 		committed Details | Review
xvimagesink patch v2 (2.85 KB, patch)
2012-03-05 10:11 UTC, Oleksij Rempel 		committed Details | Review
v4l2sink patch v1 (1.23 KB, patch)
2012-03-05 10:20 UTC, Oleksij Rempel 		committed Details | Review

Description Oleksij Rempel 2012-03-04 09:15:50 UTC 
XKeycodeToKeysym is depressed, we should replace it
Comment 1 Oleksij Rempel 2012-03-04 09:18:09 UTC 
Created attachment 208944 [details] [review]
ximagesink patch v1
Comment 2 Oleksij Rempel 2012-03-04 09:18:31 UTC 
Created attachment 208945 [details] [review]
xvimagesink patch v1
Comment 3 Tim-Philipp Müller 2012-03-04 18:14:30 UTC 
Are you sure this is the right replacement? What about XkbKeycodeToKeysym() with group=0?
Comment 4 Oleksij Rempel 2012-03-05 10:10:25 UTC 
Created attachment 208982 [details] [review]
ximagesink patch v2
Comment 5 Oleksij Rempel 2012-03-05 10:11:10 UTC 
Created attachment 208984 [details] [review]
xvimagesink patch v2

use XkbKeycodeToKeysym instead of XKeycodeToKeysym
Comment 6 Oleksij Rempel 2012-03-05 10:20:44 UTC 
Created attachment 208986 [details] [review]
v4l2sink patch v1

this patch is for plugins-good, but still same issue.
Comment 7 Tim-Philipp Müller 2012-03-05 11:37:05 UTC 
Thanks!

commit dc7c6cf4592010b531ebad51020bf505e0435bdb
Author: Oleksij Rempel (Alexey Fisher) <bug-track@fisher-privat.net>
Date:   Mon Mar 5 11:09:12 2012 +0100

    xvimagesink: don't use deprecated XKeycodeToKeysym
    
    https://bugzilla.gnome.org/show_bug.cgi?id=671299
    
    Signed-off-by: Oleksij Rempel (Alexey Fisher) <bug-track@fisher-privat.net>

commit 6d83f695b752fbf9c62d382a0233997a9b9791d7
Author: Oleksij Rempel (Alexey Fisher) <bug-track@fisher-privat.net>
Date:   Mon Mar 5 11:07:39 2012 +0100

    ximagesink: don't use deprecated XKeycodeToKeysym
    
    https://bugzilla.gnome.org/show_bug.cgi?id=671299
    
    Signed-off-by: Oleksij Rempel (Alexey Fisher) <bug-track@fisher-privat.net>


commit a83d2f70473d161dbb6c9ceff21dc214ec9db3a8
Author: Oleksij Rempel (Alexey Fisher) <bug-track@fisher-privat.net>
Date:   Mon Mar 5 11:17:30 2012 +0100

    v4l2sink: don't use deprecated XKeycodeToKeysym
    
    https://bugzilla.gnome.org/show_bug.cgi?id=671299
    
    Signed-off-by: Oleksij Rempel (Alexey Fisher) <bug-track@fisher-privat.net>