GNOME Bugzilla – Bug 671283
[patch] fixes for vte python bindings
Last modified: 2013-06-21 18:12:00 UTC
Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=556200 Description of problem: Calling vt.get_text and passing True for do_attrs causes a segfault, because the cht variable in build_attributes is never initialized. Attached is a patch which fixes the bug, and also these other bugs & warnings: 1. Refcounting in call_callback is incorrect; do not decref the callback function until after it's called. 2. Eliminate signed/unsigned warning in build_attributes; use guint instead of int. 3. Remove unused count variables from get_text and related functions. These were leftover from when the attribute code was duplicated in each. 4. match_check returns a string and an int, but the local variable was declared as int*. Change int* tag to int tag. 5. get_text and related methods are written to support callback=NULL, however the call to PyArg_ParseTupleAndKeywords makes it a required parameter. Changed instances of O|OO to |OOO. Downstream bug has patch.
0.28.x is no longer maintained, and the python bindings were removed in 0.29.x...
Sorry, didn't know 0.28.x is no longer maintained. Feel free to close this out then if thats the case.
If these changes are tested (ie by having been shipped for some time in your rpm) then I guess you could just commit them to vte-0-28 branch, even if no new release is planned. Otherwise, close the bug.
They haven't been shipped yet... but I could toss them in the fedora package and see how they do. Since 0.28.x is the last branch that supports gtk2 I think we will be using it a while in fedora.