After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671246 - _get_compat_resource endless loop with > 255 protocol info entries
_get_compat_resource endless loop with > 255 protocol info entries
Status: RESOLVED FIXED
Product: gupnp-av
Classification: Other
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-03 09:05 UTC by Jens Georg
Modified: 2019-02-22 05:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't loop endlessly on large protocol-info (1.30 KB, patch)
2012-03-18 13:39 UTC, Jens Georg 		committed Details | Review

Description Jens Georg 2012-03-03 09:05:26 UTC 
There is a problem with the VLC 2.0 integration. When trying to start an URI on the VLC renderer, gupnp-av-cp is stuck in gupnp_didl_lite_object_get_compat_resource. Not sure if its our problem, gupnp-av's or VLC's but let's start here.
Comment 1 Jens Georg 2012-03-18 12:58:37 UTC 
VLC produces an enormous protocol info string, might be that gupnp_didl_lite_object_get_compat_resource isn't exactly using a performing way to check that.
Comment 2 Jens Georg 2012-03-18 13:11:31 UTC 
yeah. 615 protocol entries to be precise. And the counter used in is_resource_compatible is a 8bit uint, causing a nice endless loop.
Comment 3 Jens Georg 2012-03-18 13:39:40 UTC 
Created attachment 210048 [details] [review]
Don't loop endlessly on large protocol-info
Comment 4 Zeeshan Ali 2012-03-18 14:41:35 UTC 
Review of attachment 210048 [details] [review]:

ACK!
Comment 5 Jens Georg 2012-03-18 19:53:16 UTC 
Attachment 210048 [details] pushed as b168dac - Don't loop endlessly on large protocol-info