GNOME Bugzilla – Bug 671244
Add support for freedesktop.org Keywords
Last modified: 2013-11-07 23:00:57 UTC
Created attachment 208896 [details] debdiff with changes to .desktop http://standards.freedesktop.org/desktop-entry-spec/latest/apa.html
Created attachment 208898 [details] [review] fixed patch added XDG Keywords, removed ayatana specific TargetEnvironment
Review of attachment 208898 [details] [review]: Please provide a format-patch against master.
Created attachment 208908 [details] [review] format-patch here's a format-patch against master
Review of attachment 208908 [details] [review]: See comments. ::: data/gedit.desktop.in.in @@ +14,3 @@ + +[Desktop Action Window] +Name=Open a New Window should this be marked for transaltion? @@ +19,3 @@ + +[Desktop Action Document] +Name=Open a New Window shouldn't this be marked for translation?
Created attachment 208911 [details] [review] format-patch with keywords/name flagged for translation good point, here's a changed format-patch with name flagged for translation.
Review of attachment 208911 [details] [review]: The commit contains the invalid email "<nathan@loki.(none)>", can you fix that?
Created attachment 208962 [details] [review] corrected patch sorry about that. i had amended the commit, but that somehow made it into the format-master.
you might want to update the description to mention the keywords or do 2 commits one for keywords and one for the action groups
Created attachment 209009 [details] [review] [PATCH] add support for fd.o desktop action spec removed keywords change, will handle in a separate commit. thanks!
One more change. Could you please use sentence case: "Open a new document" instead of "Open a New Document"? Thanks! Here's a source for that decision: https://code.launchpad.net/~bilalakhtar/gedit/unity-quicklist/+merge/63696
Never mind. Apparently Title Case is correct now. The style changed and I didn't realize it.
<pbor> seb128: btw, feel free to also push the desktop actions patch
thanks, Seb!
Reopening, the keywords part didn't get resolved in fact
Created attachment 209603 [details] [review] updated patch, adds some keywords The Keywords field is an official xdg one now and is used in gnome-shell and Unity searches, increase chances for users to find the applications they want I'm just re-using the keywords from Nathan's patch there, "Plaintext;Write;" I guess gedit could use some extra ones since it's also a nice editor for programming
Created attachment 211030 [details] [review] corrected document action Review shows I erred in the --new-document action, fixing. My apologies. I also stripped the Unity-only stuff, as it appears gnome-shell is now adopting contextual application menus?