After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671143 - Connection editor buttons do not follow GNOME HIG
Connection editor buttons do not follow GNOME HIG
Status: RESOLVED DUPLICATE of bug 642688
Product: NetworkManager
Classification: Platform
Component: nm-connection-editor
0.9.x
Other Linux
: Normal normal
: ---
Assigned To: Dan Williams
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-03-01 16:35 UTC by Gregory Merchan
Modified: 2014-01-02 15:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Gregory Merchan 2012-03-01 16:35:34 UTC
The buttons "Add", "Edit...", "Delete...", and "Save..." do not follow the GNOME HIG.

http://developer.gnome.org/hig-book/3.3/controls-buttons.html.en

The "Add" button should have ellipsis because it requires more input from the user to add a connection. Alternatively, the ellipsis can be left off if clicking the button either just adds a connection to the list or adds a connection and pops up the dialog to edit it.

The "Edit..." button should not have an ellipsis because there's no step between clicking it and letting the user edit the connection. If the button first showed a dialog that said something like "Which connection do you want to edit?", then the ellipsis would be appropriate.

The "Delete..." button should not have an ellipsis because confirmation is not required further input. This is explicitly stated in the section of the HIG that describes the use of ellipsis for menu items: http://developer.gnome.org/hig-book/3.3/menus-design.html.en#menu-item-type-command

The "Save..." button in the connection editing dialog should not have an ellipsis because there no further input required.


The GNOME HIG doesn't seem to cover this, but "Add" and "Delete" aren't usually a pair. It should be "New" and "Delete". ("Add" and "Remove" would make sense if there were another list from which to add and to which to remove items.)

I've given links to the development version of the GNOME HIG, but the relevant sections are unchanged from the other extant versions.
Comment 1 Pavel Simerda 2012-07-25 15:55:21 UTC
Although nm-connection-editor is now not used with Gnome, many things in the design guidelines are common sense.
Comment 2 Dan Winship 2014-01-02 15:45:53 UTC
I'm going to dup this to 642688 since that has further discussion of why some of the "..."s are there, and all this stuff should be fixed at the same time.

*** This bug has been marked as a duplicate of bug 642688 ***