After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671134 - Extension installation via website doesn't work
Extension installation via website doesn't work
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 672230 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-03-01 15:07 UTC by Giovanni Campagna
Modified: 2012-03-16 20:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ExtensionSystem: fix installing from website (1.47 KB, patch)
2012-03-01 15:07 UTC, Giovanni Campagna 		committed Details | Review
ExtensionSystem: fix uninstalling from website (960 bytes, patch)
2012-03-01 15:07 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-03-01 15:07:10 UTC 
See patches...
Comment 1 Giovanni Campagna 2012-03-01 15:07:33 UTC 
Created attachment 208789 [details] [review]
ExtensionSystem: fix installing from website

loadExtension() fails if the extension object is already created,
but the installation dialog was creating a dummy object in the
downloading state. Since nothing requires that (and the object is
not in the correct format anyway), just kill it.
Comment 2 Giovanni Campagna 2012-03-01 15:07:46 UTC 
Created attachment 208790 [details] [review]
ExtensionSystem: fix uninstalling from website

uninstall function was still referring to the old state and error
objects, which were removed by the refactoring.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-03-01 19:27:24 UTC 
Review of attachment 208790 [details] [review]:

I swore I removed these...
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-03-01 19:28:30 UTC 
Review of attachment 208789 [details] [review]:

The reason that we need the dummy object is so that we can set the state back to UNINSTALLED if the user clicks "No" to the install dialog, if I remember correctly
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-03-01 19:42:27 UTC 
Review of attachment 208789 [details] [review]:

Wait, no, that's another code path. I'm not sure what this is here for, then. Kill it.
Comment 6 Giovanni Campagna 2012-03-01 19:49:24 UTC 
Attachment 208789 [details] pushed as 772638c - ExtensionSystem: fix installing from website
Attachment 208790 [details] pushed as 64ce622 - ExtensionSystem: fix uninstalling from website
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-03-01 19:53:43 UTC 
OK, I'm going to come out and say it right now: we really need unit tests. This never would have happened if we had them, so I'm probably going to make it a project sometime soon to just create a bunch of unit tests that try and test every code path.
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-03-16 20:07:30 UTC 
*** Bug 672230 has been marked as a duplicate of this bug. ***