After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671132 - hlsdemux: live streams stops prematurely
hlsdemux: live streams stops prematurely
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-01 14:49 UTC by Gil Pedersen
Modified: 2016-12-30 09:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to fix issue (3.50 KB, patch)
2012-03-01 14:49 UTC, Gil Pedersen
none Details | Review
hlsdemux: don't copy data from past the end of the buffer (832 bytes, patch)
2012-06-21 14:00 UTC, Gil Pedersen
reviewed Details | Review
hlsdemux: also skip the newline character (699 bytes, patch)
2012-06-21 14:01 UTC, Gil Pedersen
none Details | Review
hlsdemux: actually preserve the input data (1.54 KB, patch)
2012-06-21 14:01 UTC, Gil Pedersen
none Details | Review
hlsdemux: make gst_m3u8 manage update_failed_count (2.29 KB, patch)
2012-06-21 14:01 UTC, Gil Pedersen
none Details | Review

Description Gil Pedersen 2012-03-01 14:49:14 UTC
Created attachment 208787 [details] [review]
patch to fix issue

When I try to play a live HLS stream the playback usually stops with an EOS after fetching the first few segments.

This is caused by a buggy implementation of the live index reload code which erroneously reports index updates.

I have attached a patch that will fix the implementation.
Comment 1 Tim-Philipp Müller 2012-03-03 15:40:16 UTC
Do you by any chance have a sample URI at hand where that happens?
Comment 2 Gil Pedersen 2012-03-05 09:09:21 UTC
(In reply to comment #1)
> Do you by any chance have a sample URI at hand where that happens?

The only URL I have is geo-blocked to danish ip's:

http://lm.gss.dr.dk/V/V01H.stream/Playlist.m3u8
Comment 3 Gil Pedersen 2012-03-23 10:21:45 UTC
If you contact me on IRC (nick kanongil) I can provide a non geo-blocked URL.
Comment 4 Gil Pedersen 2012-06-21 14:00:17 UTC
Created attachment 216918 [details] [review]
hlsdemux: don't copy data from past the end of the buffer
Comment 5 Gil Pedersen 2012-06-21 14:01:22 UTC
Created attachment 216919 [details] [review]
hlsdemux: also skip the newline character
Comment 6 Gil Pedersen 2012-06-21 14:01:35 UTC
Created attachment 216920 [details] [review]
hlsdemux: actually preserve the input data

The current implementation fails to ever detect unchanged input data, since it compares it to a modified version, rather than the original.
Comment 7 Gil Pedersen 2012-06-21 14:01:46 UTC
Created attachment 216921 [details] [review]
hlsdemux: make gst_m3u8 manage update_failed_count
Comment 8 Gil Pedersen 2012-06-21 14:04:00 UTC
I have split my patch into several smaller patches and updated it to apply to the current master.
Comment 9 Tim-Philipp Müller 2012-11-06 00:01:24 UTC
Comment on attachment 216918 [details] [review]
hlsdemux: don't copy data from past the end of the buffer

Looks like this was fixed independently (if only people would check bugzilla for patches before they go on a bug fixing spree ;)):


commit 80a3a014f566b828df9ad68b4ee9925d3dc103ec
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri Oct 12 15:09:07 2012 +0200

    hlsdemux: Fix invalid read
Comment 10 Sebastian Dröge (slomo) 2014-01-05 10:34:24 UTC
Is this still a problem with latest GIT or 1.2.2? Does someone have a stream to reproduce?
Comment 11 Viacheslav Dubrovskyi 2014-02-27 17:59:54 UTC
Yes, still problem with 1.2.3
Try http://46.249.55.30:80/first_1200_00.m3u8?user=zixi_test for test
Comment 12 Thiago Sousa Santos 2014-12-24 13:52:27 UTC
The whole hlsdemux codebase has been rewritten. Is this still an issue?
Comment 13 Tim-Philipp Müller 2016-12-30 09:35:35 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment.
Thanks!