After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671130 - [0.11] use libfffi-based generic marshaller instead of glib-genmarshal
[0.11] use libfffi-based generic marshaller instead of glib-genmarshal
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.11.x
Other Linux
: Normal enhancement
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-01 14:31 UTC by Olivier Blin
Modified: 2012-09-24 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Olivier Blin 2012-03-01 14:31:22 UTC
Currently, gstreamer is using glib-genmarshal to generate type-specific marshallers.
This can be troublesome when cross-compiling, since a compatible glib-genmarshal needs to be available on the host.

It would nice to use the new g_cclosure_marshal_generic() function instead. This is a generic marshaller based on libffi, it is available starting from glib 2.30.
Comment 1 Sebastian Dröge (slomo) 2012-03-02 09:43:59 UTC
As a first step we should probably stop installing gstmarshal.h. Then we can change it to the generic marshaller later without worrying about keeping the old functions in our public API.
Comment 2 Sebastian Dröge (slomo) 2012-03-02 10:07:00 UTC
commit cfe71423f00461e238ec6b121a539cdc73578dce
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri Mar 2 11:05:48 2012 +0100

    gst: Remove gstmarshal.[ch] completely and use the generic marshaller
    
    Fixes bug #671130.

commit 441402f9d54414950eaca3ff782c74f221123675
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri Mar 2 10:51:42 2012 +0100

    gst: Don't install gstmarshal.h
    
    The generic, FFI based marshaller should be used instead of these
    and we definitely shouldn't export the marshallers in our public API.