After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671107 - flacenc: generate seek tables every 10 seconds by default
flacenc: generate seek tables every 10 seconds by default
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.x
Other Linux
: Normal normal
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 670854
 
 
Reported: 2012-03-01 09:29 UTC by Ross Burton
Modified: 2012-03-12 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Ross Burton 2012-03-01 09:29:46 UTC
When using GstEncodingProfile, the FLAC encoder doesn't generate a seek table.  The flacenc command line tool creates a seek table with entries every 10s, so GStreamer should arguably do the same.
Comment 1 Ross Burton 2012-03-01 09:31:57 UTC
In gst-plugins-good/ext/flac/gstflacenc.c:
-#define DEFAULT_SEEKPOINTS 0
+#define DEFAULT_SEEKPOINTS -10

Should do the trick.
Comment 2 Wim Taymans 2012-03-12 14:28:37 UTC
commit 265a5bfa9bd356047df8db3c3f639f19255cc9d7
Author: Ross Burton <ross at burtonini.com>
Date:   Mon Mar 12 15:27:27 2012 +0100

    flacenc: generate seektables every 10 sec by default
    
    Since this is what the command line tool does as well, it seems like
    a better default.