After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671103 - plugin: Remove silly wrapper APIs
plugin: Remove silly wrapper APIs
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-01 06:07 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-03-08 23:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
plugin: Remove silly wrapper APIs (9.49 KB, patch)
2012-03-01 06:07 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
Don't depend on MetaPlugin API (3.09 KB, patch)
2012-03-01 06:08 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-03-01 06:07:48 UTC 
See patch.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-03-01 06:07:50 UTC 
Created attachment 208759 [details] [review]
plugin: Remove silly wrapper APIs

For some reason, the Mutter Plugin APIs have silly wrappers around core
mutter operations. Remove them.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-03-01 06:08:19 UTC 
Created attachment 208760 [details] [review]
Don't depend on MetaPlugin API

It's a silly wrapper API that we can live without
Comment 3 Owen Taylor 2012-03-08 21:24:37 UTC 
Review of attachment 208759 [details] [review]:

OK to commit with a rewritten commit message:

 Remove unneeded wrapper APIs

 Mutter originally started out with the idea that only a subset of the total API was
 exposed to plugins, so some APIs are duplicated on MutterPlugin. We've long since
 abandoned that idea; remove these wrappers.
Comment 4 Owen Taylor 2012-03-08 21:56:14 UTC 
Review of attachment 208760 [details] [review]:

===
Don't depend on on removed MetaPlugin APIs

Several MetaPlugin APIs that were just wrappers around other functions
were removed - switch to using the other functions directly.
===

(The more factual the commit message the better)