After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671088 - Update desktop file to support Unity
Update desktop file to support Unity
Status: RESOLVED WONTFIX
Product: totem
Classification: Core
Component: Movie player
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-02-29 21:45 UTC by Nekhelesh
Modified: 2012-04-23 15:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Desktop file with support for quicklists. (951 bytes, text/plain)
2012-02-29 21:45 UTC, Nekhelesh
  Details
Desktop File Patch (951 bytes, text/plain)
2012-02-29 21:54 UTC, Nekhelesh
  Details
Desktop File Patch (865 bytes, patch)
2012-03-01 00:58 UTC, Nekhelesh
rejected Details | Review

Description Nekhelesh 2012-02-29 21:45:54 UTC
Created attachment 208723 [details]
Desktop file with support for quicklists.

The desktop file need to be updated to include quicklist support for Unity. I have attached the patch providing this support.
Comment 1 Nekhelesh 2012-02-29 21:54:45 UTC
Created attachment 208724 [details]
Desktop File Patch
Comment 2 Bastien Nocera 2012-02-29 22:19:04 UTC
Neither of those are patches, they won't be getting translated properly, and there's no explanation as to why the particular actions were chosen.
Comment 3 Nekhelesh 2012-03-01 00:11:18 UTC
How do I branch the code and upload my patch? The change is basically to the the desktop file to include support for quicklists for unity and Keywords according to the new XDG specification.
Comment 4 Nekhelesh 2012-03-01 00:56:45 UTC
Alright, I have attached a new patch that you requested. The reason for the patch is the following,

- Totem is the default player in Ubuntu whose function can be enhanced by the use of quicklists to support Unity

- I have also added Keywords support as per the new XDG specifications.
Comment 5 Nekhelesh 2012-03-01 00:58:03 UTC
Created attachment 208736 [details] [review]
Desktop File Patch
Comment 6 André Klapper 2012-03-05 14:12:45 UTC
Nekhelesh: You probably wanted to link to https://wiki.ubuntu.com/Unity/LauncherAPI#Quicklists . Please don't expect GNOME developers to follow development of all those desktop shells in this world. ;-)
Comment 7 André Klapper 2012-03-05 14:18:21 UTC
(In reply to comment #4)
> - Totem is the default player in Ubuntu whose function can be enhanced by the
> use of quicklists to support Unity
> 
> - I have also added Keywords support as per the new XDG specifications.

These are two different things and hence should probably be in two separate patches.
Comment 8 Bastien Nocera 2012-03-05 14:21:23 UTC
(In reply to comment #6)
> Nekhelesh: You probably wanted to link to
> https://wiki.ubuntu.com/Unity/LauncherAPI#Quicklists . Please don't expect
> GNOME developers to follow development of all those desktop shells in this
> world. ;-)

I know about those downstream changes. My comments still apply, no
translations, and no explanations as to why each entry was chosen. Whoever
wrote the "guide" should correct the guide to include those.
Comment 9 Michael Hall 2012-03-05 17:42:15 UTC
Bastien, what explanations are you asking for?  I will gladly add any additional instructions that help get these contributions upstream.

The instructions given were for .desktop files in their final form, so it doesn't instruct contributors to prefix their fields with an underscore.  If that is all you need for translations on these entries, I will help Nekhelesh add them.
Comment 10 Bastien Nocera 2012-04-20 12:59:08 UTC
Review of attachment 208736 [details] [review]:

That's what I'm talking about. The instructions that the original reporter is following don't mention basics like i18n support.

::: data/totem.desktop.in.in.in
@@ +19,3 @@
+
+[Desktop Action Play]
+Name=Play/Pause

Not i18n'ed.

@@ +24,3 @@
+
+[Desktop Action Next]
+Name=Next

Ditto.

@@ +29,3 @@
+
+[Desktop Action Previous]
+Name=Previous

Ditto.

@@ +34,3 @@
+
+[Desktop Action Mute]
+Name=Mute

Ditto.

@@ +39,3 @@
+
+[Desktop Action Fullscreen]
+Name=Fullscreen

Ditto.
Comment 11 Bastien Nocera 2012-04-23 15:12:19 UTC
Discussed this today on #ubuntu-desktop with Michael and Sebastien Bacher. Things that came out were:
- it's using the "old way" of adding static actions
- it's missing i18n support (despite the linked wiki page doing the right thing)
- it breaks the generation of the desktop file in Totem's build system (as Totem appends the list of mime-types at the end of the .desktop files, and this would be in the way, instead of being in the main section)
- most of those actions don't work when totem isn't running, so they would make more sense as run-time actions, rather than static actions.

I mentioned that for media players it would probably have been better to use MPRIS support to enable "correct" support for this (such as Play/Pause only being available when something is playing, or the Fullscreen menu item having the correct state).

Closing as WONTFIX as we don't want those static actions.