After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671086 - Remove muted log handler
Remove muted log handler
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-29 21:33 UTC by Giovanni Campagna
Modified: 2012-03-01 13:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main: Remove muted_log_handler (1.85 KB, patch)
2012-03-01 07:58 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Giovanni Campagna 2012-02-29 21:33:48 UTC 
These days GLib automatically filters g_debug() unless the appropriate env var is set, which means that all muted_log_handler() blocks is filtered by the default log handler. On the other hand, muted_log_handler() gets in the way when you actually want to debug one of the muter libraries.

I'd say it's time to remove it.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-03-01 03:03:22 UTC 
Was there meant to be a patch here?
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-03-01 07:58:59 UTC 
Created attachment 208767 [details] [review]
main: Remove muted_log_handler

Since glib turns off g_debug spew by default, we don't need to mute
it ourselves.
Comment 3 Giovanni Campagna 2012-03-01 13:05:04 UTC 
Review of attachment 208767 [details] [review]:

It seemed straightforward enough not to warrant a patch...
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-03-01 13:09:25 UTC 
Attachment 208767 [details] pushed as 98aa61e - main: Remove muted_log_handler