Bug 671079 – [PATCH] on fedora, installing gstreamer-plugins-entrans causes pitivi to fail to start

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 671079 - [PATCH] on fedora, installing gstreamer-plugins-entrans causes pitivi to fail to start


Summary:	[PATCH] on fedora, installing gstreamer-plugins-entrans causes pitivi to fail...


Status:	RESOLVED OBSOLETE

Product:	pitivi
Classification:	Other
Component:	General
Version:	0.15.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	0.91
Assigned To:	Pitivi maintainers
QA Contact:	Pitivi maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2012-02-29 18:16 UTC by Cole Robinson
Modified:	2012-03-30 01:16 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Ignore unknown stream types at startup (2.53 KB, text/plain) 2012-02-29 18:16 UTC, Cole Robinson	Details

Description Cole Robinson 2012-02-29 18:16:20 UTC

Created attachment 208708 [details]
Ignore unknown stream types at startup

On fedora 16, if I have the gstreamer-plugins-entrans package installed, pitivi from git fails to start:

Traceback (most recent call last):

+ Trace 229767

File "./installdir/bin/pitivi", line 134 in <module>
```
_run_pitivi()
```
File "./installdir/bin/pitivi", line 129 in _run_pitivi
```
sys.exit(ptv.main(sys.argv))
```
File "pitivi/application.py", line 514 in main
```
ptv = StartupWizardGuiPitivi(debug=options.debug)
```
File "pitivi/application.py", line 371 in __init__
```
FullGuiPitivi.__init__(self, debug)
```
File "pitivi/application.py", line 264 in __init__
```
InteractivePitivi.__init__(self, debug)
```
File "pitivi/application.py", line 212 in __init__
```
Pitivi.__init__(self)
```
File "pitivi/application.py", line 128 in __init__
```
self.effects = EffectsHandler()
```
File "pitivi/effects.py", line 123 in __init__
```
self._setAllEffects()
```
File "pitivi/effects.py", line 141 in _setAllEffects
```
added = self.addStreams(element_factory, effect)
```
File "pitivi/effects.py", line 189 in addStreams
```
stream = get_stream_for_pad(pad)
```
File "pitivi/stream.py", line 373 in get_stream_for_pad
```
stream.pad_id = pad_id
```

AttributeError: 'NoneType' object has no attribute 'pad_id'



The problem is that the entrans package causes pitivi to see a stream with
stream_type == "application", which get_stream_for_caps doesn't explicitly
handle.

Comment 1 Cole Robinson 2012-02-29 18:20:37 UTC

This is an unfortunate issue since the root cause is non obvious, so it makes pitivi look bad.

I'm sure most people aren't actually using the gstreamer entrans package for anything, and just ended up in this situation due to yum install gstreamer-plugins\* which is what I did :)

Comment 2 Jean-François Fortin Tam 2012-03-03 16:11:35 UTC

Hi Cole,
I installed gstreamer-plugins-entrans (on Fedora 16) and started pitivi without problems on the "ges" branch (haven't tried master, I suspect the bug occurs only there). Also, I've done: 

git grep get_stream_for_pad pitivi/
git grep stream pitivi/effects.py
git grep PAD_SINK pitivi/

...and it seems like the offending code is gone completely, which makes me think that it would not be an issue in the next release.

If you have time, perhaps you can check out the ges version and see if it's still a problem (see http://wiki.pitivi.org/wiki/Building_with_GES). As it stands, the ges version is the only development focus.

Comment 3 Jean-François Fortin Tam 2012-03-03 16:12:32 UTC

Also, I wanted to say thanks for the patch/kind attention you give to pitivi :)

Comment 4 Cole Robinson 2012-03-03 18:38:19 UTC

Cool, if it's fixed in ges branch/next major version that's fine with me. Though if yall are planning on continuing 0.15.x releases it might make sense to apply my patch or a similar change to master so other distros pick it up, I recalling finding a debian bz for this issue as well.