After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671050 - Search only works with lowercase letters
Search only works with lowercase letters
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
0.3.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-02-29 11:54 UTC by drago01
Modified: 2012-02-29 19:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
search: Fix searching by uppercase letters (1.63 KB, patch)
2012-02-29 19:47 UTC, drago01 		committed Details | Review

Description drago01 2012-02-29 11:54:20 UTC 
When I have a document called "Testfile.odt" I can find it by searching for "test" but not for "Test" which is confusion and absolutely non obvious to the users.

Shouldn't we just convert the string to lowercase before passing it to the search API?
Comment 1 drago01 2012-02-29 19:47:30 UTC 
Created attachment 208713 [details] [review]
search: Fix searching by uppercase letters

Currently search only works with lowercase letters, using uppercase ones always
results into no result. Fix that by converting the user supplied string to
lowercase before passing it down to the search APIs.
Comment 2 Cosimo Cecchi 2012-02-29 19:49:02 UTC 
Review of attachment 208713 [details] [review]:

Thanks, looks good to me.
Comment 3 drago01 2012-02-29 19:52:22 UTC 
Attachment 208713 [details] pushed as 5ffa314 - search: Fix searching by uppercase letters