After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671039 - Add Keyword for looking in both Gnome-shell and Unity
Add Keyword for looking in both Gnome-shell and Unity
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-29 09:59 UTC by Didier Roche
Modified: 2017-09-26 17:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add some keywords to desktop files following latest XDG spec (325 bytes, patch)
2012-02-29 09:59 UTC, Didier Roche 		none Details | Review
Add viewer to desktop Keywords. (892 bytes, patch)
2017-07-20 06:29 UTC, Didier Roche 		none Details | Review
evince.desktop: add "viewer" to desktop keywords (908 bytes, patch)
2017-07-20 06:35 UTC, Didier Roche 		committed Details | Review

Description Didier Roche 2012-02-29 09:59:04 UTC 
Created attachment 208666 [details] [review]
Add some keywords to desktop files following latest XDG spec

The latest XDG specification know support the "Keyword:" in desktop file for making components way easier to search for in, for instance, gnome-shell and unity.

People from the ubuntu community started to report some patches for it. Here is the one for this component.
Comment 1 Bastien Nocera 2017-07-19 16:31:54 UTC 
There were keywords added in:

commit 396040d8754e8dcbfee517509e65c76a51938230
Author: Matthias Clasen <mclasen@redhat.com>
Date:   Sun Nov 4 22:56:59 2012 -0500

    Add keywords to the desktop file
    
    This makes gnome-shell search more pleasant and useful.

+_Keywords=pdf;ps;postscript;dvi;xps;djvu;tiff;document;presentation;

Can you please provide a new git-formatted patch if you want to add new keywords to this?
Comment 2 Bastien Nocera 2017-07-19 16:32:22 UTC 
Review of attachment 208666 [details] [review]:

Marking as needs-work based on last comment
Comment 3 Didier Roche 2017-07-20 06:29:06 UTC 
Oh, completely forgot this bug with the years ;)
I saw that the list has already been completed, but "document" is duplicated between Keywords and Name contrary to "viewer", which is a common name used to look for evince.

Added a patch on latest git master to add that one.
Comment 4 Didier Roche 2017-07-20 06:29:39 UTC 
Created attachment 356007 [details] [review]
Add viewer to desktop Keywords.
Comment 5 Bastien Nocera 2017-07-20 06:32:03 UTC 
Review of attachment 356007 [details] [review]:

Add "evince.desktop: " to the subject, and this looks fine.
Comment 6 Didier Roche 2017-07-20 06:35:54 UTC 
Created attachment 356008 [details] [review]
evince.desktop: add "viewer" to desktop keywords

And here we go!
Comment 7 Bastien Nocera 2017-07-20 06:39:57 UTC 
Review of attachment 356008 [details] [review]:

You didn't need to attach a new version, I trust you to be able to amend a subject ;)
Comment 8 Piotr Drąg 2017-09-26 16:32:11 UTC 
Commit 6e29a9aba5f6743bb0c3ea043996abfea5adbd31 broke the string freeze. Please revert it ASAP, or branch for gnome-3-26 before it.
Comment 9 Germán Poo-Caamaño 2017-09-26 16:40:00 UTC 
Ooops. I had the understanding it was already branched (and I did not check it). Sorry :-)
Comment 10 Germán Poo-Caamaño 2017-09-26 17:22:21 UTC 
There is now a gnome-3-26 synced with the release tag 3.26.0
Comment 11 Piotr Drąg 2017-09-26 17:23:55 UTC 
Added to Damned Lies: https://l10n.gnome.org/module/evince/#gnome-3-26

Thank you!