After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671006 - keygrab: don't translate Alt+Print to SysRq
keygrab: don't translate Alt+Print to SysRq
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-02-28 20:36 UTC by Cosimo Cecchi
Modified: 2012-03-22 05:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keygrab: don't translate Alt+Print to SysRq (1.43 KB, patch)
2012-02-28 20:36 UTC, Cosimo Cecchi 		committed Details | Review
cellrendereraccel: don't translate Alt+Print to SysRq (2.15 KB, patch)
2012-02-28 20:38 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-02-28 20:36:00 UTC 
This fixes window screenshots not working properly. See commit message for the rationale.
Comment 1 Cosimo Cecchi 2012-02-28 20:36:01 UTC 
Created attachment 208632 [details] [review]
keygrab: don't translate Alt+Print to SysRq

We want to use Alt+Print for screenshot keybindings, so we have to avoid
translating it into SysRq, since that's what the keymap would dictate.
After talking with Owen, it sounds like doing this generically would be
a lot of work and quite hairy code, so hardcoding this should be OK.
Comment 2 Cosimo Cecchi 2012-02-28 20:38:21 UTC 
Created attachment 208633 [details] [review]
cellrendereraccel: don't translate Alt+Print to SysRq

We also need this similar patch to GtkCellRendererAccel to have gnome-control-center report Alt+Print in the Shortcuts panel when trying to grab the key.
Comment 3 Bastien Nocera 2012-02-29 10:41:21 UTC 
Review of attachment 208633 [details] [review]:

Looks good to me.

::: gtk/gtkcellrendereraccel.c
@@ +457,3 @@
+    {
+      /* HACK: we don't want to use SysRq as a keybinding, so we avoid
+       * its translation entirely.

This has less details than the comment in g-s-d.
Comment 4 Matthias Clasen 2012-03-02 12:09:29 UTC 
Wouldn't it be better to do this inside _gtk_translate_keyboard_accel_state ?
Comment 5 Matthias Clasen 2012-03-22 05:12:09 UTC 
Review of attachment 208633 [details] [review]:

committed