After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670968 - hlsdemux sets fetcher's location twice
hlsdemux sets fetcher's location twice
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-28 11:57 UTC by Xavier Queralt
Modified: 2012-02-29 08:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
hlsdemux: don't set the fetcher's location twice (965 bytes, patch)
2012-02-28 11:57 UTC, Xavier Queralt
committed Details | Review

Description Xavier Queralt 2012-02-28 11:57:16 UTC
Created attachment 208573 [details] [review]
hlsdemux: don't set the fetcher's location twice

In the hlsdemuxer, the fetcher is created by calling gst_element_make_from_uri where the uri of the newly created element is already set.

Latter, the hlsdemuxer sets the fetcher's location property directly. This isn't a problem when using HTTP but it is when trying to play a local file because filesrc doesn't handle file:// URIs in the location property.

I've attached a patch which removes the line where the location is set to prevent this.
Comment 1 Sebastian Dröge (slomo) 2012-02-29 08:53:22 UTC
commit b5004e058b6da66dd3f5808b5e67bad8b29bf4cd
Author: Xavier Queralt <xqueralt@gmail.com>
Date:   Tue Feb 14 11:57:00 2012 +0100

    hlsdemux: don't set the fetcher's location twice
    
    Calling gst_element_make_from_uri already does it and filesrc
    fails when using file protocol in a location