GNOME Bugzilla – Bug 670929
Add Unity Launcher Quicklist
Last modified: 2017-04-10 15:37:51 UTC
Add action items for display in the Unity Launcher's Quicklist https://wiki.ubuntu.com/Unity/LauncherAPI
Created attachment 208540 [details] [review] Patch to add feature
Created attachment 208541 [details] [review] Patch to add feature. I made a mistake in my original patch. This has the fix.
Review of attachment 208541 [details] [review]: The values for X-Ayatana-Desktop-Shortcuts need to actually match the function values. See https://wiki.ubuntu.com/Unity/LauncherAPI#Quicklists
Also, https://wiki.ubuntu.com/Unity/LauncherAPI#Quicklists does not list "TargetEnvironment" but "OnlyShowIn".
Name should probably be _Name (same for other identifiers) so its value is marked as translatable.
Created attachment 210137 [details] [review] New patch with freedesktop.org spec and translatable.
Thanks André. The specification changed from a Unity specific one, to one matching the freedesktop.org That's why what I submitted was differenct from the documentation at the time you pulled it up. I've got a new patch using the new specification and using _name for translations.
Comment on attachment 210137 [details] [review] New patch with freedesktop.org spec and translatable. >=== modified file 'data/epiphany.desktop.in.in' >--- data/epiphany.desktop.in.in 2012-01-25 16:55:38 +0000 >+++ data/epiphany.desktop.in.in 2012-02-25 16:04:55 +0000 >@@ -14,3 +14,15 @@ > X-GNOME-Bugzilla-Version=@VERSION@ > Categories=Network;GNOME;GTK;WebBrowser; > MimeType=text/html;text/xml;application/xhtml+xml;x-scheme-handler/http;x-scheme-handler/https; >+ >+Actions=Screen;Window >+ >+[Desktop Action NewWindow] >+_Name=Open a New Window >+Exec=epiphany --new-window >+OnlyShowIn=Unity >+ >+[Desktop Action PrivateWindow] >+_Name=Open a New Window in private mode >+Exec=epiphany --private-instance >+OnlyShowIn=Unity
To be consistent with the freedesktop specs, please add a semicolon to the end of the Actions line and the OnlyShowIn lines.
Comment on attachment 210137 [details] [review] New patch with freedesktop.org spec and translatable. Per previous comments this seems to need some work still.
Created attachment 346880 [details] [review] Add explicit New Window action This is needed for Unity but works fine in GNOME. This is the same string used by gedit and elsewhere.
Review of attachment 346880 [details] [review]: It's just ignored in GNOME? Can you show me a screenshot please?
Created attachment 346922 [details] Screenshot of Web on GNOME after patch Did you want a screenshot of Unity or of GNOME? Before or after? Here's a screenshot using Dash to Dock but it looks the same in the Activities Overview. I think the .desktop Action has to be named new-window for there not to be a duplicate "New Window" in GNOME.
This is what gedit and nautilus already do. https://git.gnome.org/browse/nautilus/commit/?id=a44b4996fa
Review of attachment 346880 [details] [review]: OK, I like it better this way anyway, since it removes the ugly separator between New Window and New Incognito Window. I think it's not a string freeze break since we already have New Window in the app menu. Let me know if you need me to commit it.
Attachment 346880 [details] pushed as 942502e - Add explicit New Window action
I should email the translators list to let them know, right?
I don't think so, because we already have a "New Window" string; we shouldn't need any translation updates for this. If it was required, I would have asked to hold this until 3.26, since we are under string freeze and this doesn't seem worth a string freeze break.
There was no “New Window” string. You must be thinking about “_New Window”, which is a completely different string. :)
Ugh, sorry. :( The app menu entries all have totally unnecessary underscores. Bummer. Jeremy, I'm going to back this out to avoid adding the new string this late in the game. Feel free to add it as a downstream patch for now. I'll commit it next cycle. I'll also remove the useless underscores from the app menu strings at that time. They don't belong because accelerators are specified manually in the UI file, not by using underscores.
Michael, no problem. I already distro-patched it for Ubuntu 17.04 which is sufficient for the Unity test case.
Attachment 346880 [details] pushed as 681e320 - Add explicit New Window action