After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670910 - st-container: Remove st_container_get_children_list
st-container: Remove st_container_get_children_list
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-27 20:15 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-02-27 20:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
st-container: Remove st_container_get_children_list (27.66 KB, patch)
2012-02-27 20:15 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-02-27 20:15:30 UTC 
Let's try to land this modified patch first. ricotz spotted some memory
leaks which were my mistake. Move this one up earlier in the stack to
hopefully help alleviate that.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-02-27 20:15:32 UTC 
Created attachment 208516 [details] [review]
st-container: Remove st_container_get_children_list

Replace it with the new actor iteration APIs. This fixes a few
unintentional memory leaks - st_container_get_children_list
returns an internal list, and clutter_actor_get_children_list
allocates a new list.

https://bugzilla.gnome.org/show_bug.cgi?id=670034
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-02-27 20:16:12 UTC 
Whoops, I meant to use "git bz attach", but this works too, I guess.
Comment 3 drago01 2012-02-27 20:19:03 UTC 
Review of attachment 208516 [details] [review]:

Looks good but no idea why we need a separate bug for this.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-02-27 20:22:37 UTC 
Attachment 208516 [details] pushed as d2aab9d - st-container: Remove st_container_get_children_list