GNOME Bugzilla – Bug 670872
Should be less sensitive to accentuated chars
Last modified: 2012-03-26 10:39:40 UTC
gnome-contacts doesn't suggest me to name my contact "Alban Crequy" and "Alban Créquy" together while they are obviously the same person. Folks could be smarter and use the same kind of code Empathy does when live searching for contacts; it does some magic to deal in a more convenient way with accentuated chars.
Created attachment 210536 [details] [review] Make the potential match code insensitive to accentuation and case https://www.gitorious.org/folks/folks/commits/670872-match-accented-chars
Review of attachment 210536 [details] [review]: Looks good to me.
Comment on attachment 210536 [details] [review] Make the potential match code insensitive to accentuation and case commit f8e59f0d0a051ed9dcfeab2467b78ca1aabec741 Author: Philip Withnall <philip@tecnocode.co.uk> Date: Sat Mar 24 22:18:21 2012 +0000 Bug 670872 — Should be less sensitive to accentuated chars Strip accented characters from names and make them all lower case when searching for potential matches between individuals. This uses a modified version of Empathy's live search code to allow for string matches regardless of case or accentuation. The commit also fixes the potential match code to handle UTF-8 properly, which it wasn't doing before. This includes a test case. Closes: https://bugzilla.gnome.org/show_bug.cgi?id=670872 NEWS | 1 + folks/potential-match.vala | 112 ++++++++++++++++++++++++++++++++++++---- tests/tracker/match-name.vala | 11 ++++ 3 files changed, 112 insertions(+), 12 deletions(-) commit 478389889e05bbbadcc079734ac6519b9e3c673b Author: Philip Withnall <philip@tecnocode.co.uk> Date: Sat Mar 24 22:15:25 2012 +0000 tests: Tidy up the tracker/match-name test a little Reduce code duplication somewhat. tests/tracker/match-name.vala | 50 +++++++--------------------------------- 1 files changed, 9 insertions(+), 41 deletions(-)