After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670852 - [0.11] collectpads2 api review
[0.11] collectpads2 api review
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.11.x
Other Linux
: Normal blocker
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-26 22:11 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2012-09-24 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Stefan Sauer (gstreamer, gtkdoc dev) 2012-02-26 22:11:07 UTC
1) collectpads2 has 0 direct tests
- the collectpads test should be reviewed and ported

2) collectpads2 still has stuff like gst_collect_pads2_is_active and gst_collect_pads2_collect which are unimplemented and are now part of the API again :/

3) does it make sense to keep gst_collect_pads2_add_pad and gst_collect_pads2_add_pad_full?

4) one still need the hack to override/extend the event function (e.g. in adder, avimux, ...)
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2012-02-27 10:14:11 UTC
Regarding 4) there is gst_collect_pads2_set_event_function() which the adder port did not use.
Comment 2 Tim-Philipp Müller 2012-07-24 14:28:48 UTC
Any changes better land soon..
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2012-07-24 19:03:53 UTC
Tests have been ported.
Comment 4 Tim-Philipp Müller 2012-07-24 19:04:52 UTC
Also, GAP event handling, see bug #678385.
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2012-07-24 19:07:58 UTC
Will make patches for 2 & 3
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2012-07-24 20:18:06 UTC
2) done, 3) todo
Comment 7 Tim-Philipp Müller 2012-09-12 00:04:20 UTC
Last chance...
Comment 8 Stefan Sauer (gstreamer, gtkdoc dev) 2012-09-12 07:00:22 UTC
I'll do 3) tonight.
Comment 9 Stefan Sauer (gstreamer, gtkdoc dev) 2012-09-12 19:23:07 UTC
Fixed in gstreamer + gst-*