GNOME Bugzilla – Bug 670796
(patch) Show commands when building documentation with make
Last modified: 2012-11-13 22:30:03 UTC
Normally, when you run 'make V=1', you see all commands that are run. The gtk-doc{.notmpl}.make files do not work like this. Instead, they echo a hardcoded message and always hide the build commands. A patch to correct this follows.
Created attachment 208413 [details] [review] 0001-Show-commands-when-building-documentation-with-make-.patch
Review of attachment 208413 [details] [review]: Ideally this would also need to be applied to the make files under test/ ::: gtk-doc.make @@ +81,2 @@ setup-build.stamp: + $(GTK_DOC_V_SETUP)if test "$(abs_srcdir)" != "$(abs_builddir)" ; then \ Are you intentionally dropping the '-' ? ::: gtk-doc.notmpl.make @@ +81,2 @@ setup-build.stamp: + $(GTK_DOC_V_SETUP)if test "$(abs_srcdir)" != "$(abs_builddir)" ; then \ Again the '-'
(In reply to comment #2) > Review of attachment 208413 [details] [review]: > > Ideally this would also need to be applied to the make files under test/ > > ::: gtk-doc.make > @@ +81,2 @@ > setup-build.stamp: > + $(GTK_DOC_V_SETUP)if test "$(abs_srcdir)" != "$(abs_builddir)" ; then \ > > Are you intentionally dropping the '-' ? No, i think dropping it was a mistake. > > ::: gtk-doc.notmpl.make > @@ +81,2 @@ > setup-build.stamp: > + $(GTK_DOC_V_SETUP)if test "$(abs_srcdir)" != "$(abs_builddir)" ; then \ > > Again the '-' Again a mistake.
I pushed you changed + the '-' revert.
Comment on attachment 208413 [details] [review] 0001-Show-commands-when-building-documentation-with-make-.patch with small mods.
Hib, there seems to be still problems with the change. One thing is that I have to explicitly run make V=0 to get rid of the verbose output. Shouldn't this be the default, especially when using --enable-silent-rules at configure time?
Review of attachment 208413 [details] [review]: ::: gtk-doc.make @@ +97,3 @@ +GTK_DOC_V_SCAN=$(GTK_DOC__v_SCAN_$(V)) +GTK_DOC__v_SCAN=$(GTK_DOC__v_SCAN_$(AM_DEFAULT_VERBOSITY)) This is supposed to be GTK_DOC__v_SCAN_=$(GTK_DOC__v_SCAN_$(AM_DEFAULT_VERBOSITY)) (you forgot the '_' at the end of the var. Also for all other vars below. Testing patches is appreciated.