After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670753 - screencasts and screenshots use different filename formats
screencasts and screenshots use different filename formats
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-24 15:48 UTC by William Jon McCann
Modified: 2012-02-27 10:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
recorder: Use locale-dependent format for %d in filename (1.92 KB, patch)
2012-02-24 17:17 UTC, Florian Müllner
committed Details | Review
recorder: Add support for %t in filename pattern (1.54 KB, patch)
2012-02-24 17:17 UTC, Florian Müllner
none Details | Review
recorder: Change default output filename (1.81 KB, patch)
2012-02-24 17:17 UTC, Florian Müllner
committed Details | Review
recorder: Add support for %t in filename pattern (1.54 KB, patch)
2012-02-24 17:54 UTC, Florian Müllner
committed Details | Review

Description William Jon McCann 2012-02-24 15:48:15 UTC
It probably makes sense to make screenshots and screencasts use similar formats for the filenames.

Right now we have:
shell-20120224-1.webm
Screenshot at 2012-02-22 18:28:25.png

Also, it isn't really a "shell" screencast just a screencast.
Comment 1 Florian Müllner 2012-02-24 17:17:36 UTC
Created attachment 208363 [details] [review]
recorder: Use locale-dependent format for %d in filename

Currently %d hardcodes a date format of YYYYMMDD, use the preferred
format for the current locale instead.
Comment 2 Florian Müllner 2012-02-24 17:17:44 UTC
Created attachment 208364 [details] [review]
recorder: Add support for %t in filename pattern

Similar to the %d format for the current date, the new %t format
can be used to use the current time in screencast filenames.
Comment 3 Florian Müllner 2012-02-24 17:17:49 UTC
Created attachment 208365 [details] [review]
recorder: Change default output filename

Use "Screencast at 2009-03-11 00:08:15.webm" instead of
"shell-20090311b-2.webm".
Comment 4 Florian Müllner 2012-02-24 17:22:09 UTC
The new filename looks friendlier, but is vulnerable to the problem mentioned here:

 /* If a filename is explicitly specified without %u then we assume the user
  * is fine with over-writing the old contents; putting %u in the default
  * should avoid problems with malicious symlinks.
  */
Comment 5 Florian Müllner 2012-02-24 17:54:33 UTC
Created attachment 208369 [details] [review]
recorder: Add support for %t in filename pattern

Woops, a typo sneaked in ...
Comment 6 drago01 2012-02-24 22:43:24 UTC
Review of attachment 208363 [details] [review]:

Looks good.
Comment 7 drago01 2012-02-24 22:44:14 UTC
Review of attachment 208365 [details] [review]:

Looks good.
Comment 8 drago01 2012-02-24 22:44:40 UTC
Review of attachment 208369 [details] [review]:

Looks good.
Comment 9 Florian Müllner 2012-02-24 23:19:27 UTC
Attachment 208363 [details] pushed as 9144412 - recorder: Use locale-dependent format for %d in filename
Attachment 208365 [details] pushed as 7cc1bdb - recorder: Change default output filename
Attachment 208369 [details] pushed as 60557f4 - recorder: Add support for %t in filename pattern
Comment 10 Ray Strode [halfline] 2012-02-25 00:00:54 UTC
After some discussion on IRC we're going to change this to use the preposition "at" instead of "from" since "at" sort of makes it sound like the files are from the future instead of from the past.
Comment 11 William Jon McCann 2012-02-25 23:08:46 UTC
As long as the change is in both places, right?
Comment 12 Florian Müllner 2012-02-27 10:56:13 UTC
Yes, the change has been made in both modules. While we're at it - should both names be marked for translation?