After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670732 - gnome-pty-helper: Respect SUID_CFLAGS and SUID_LDFLAGS
gnome-pty-helper: Respect SUID_CFLAGS and SUID_LDFLAGS
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-24 10:40 UTC by Vincent Untz
Modified: 2012-02-24 12:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-pty-helper: Respect SUID_CFLAGS and SUID_LDFLAGS (948 bytes, patch)
2012-02-24 10:40 UTC, Vincent Untz 		none Details | Review
gnome-pty-helper: Respect SUID_CFLAGS and SUID_LDFLAGS (1.45 KB, patch)
2012-02-24 11:49 UTC, Vincent Untz 		committed Details | Review

Description Vincent Untz 2012-02-24 10:40:02 UTC 
This is a good way for distributors to use -fPIE/-pie when building vte. This is useful for suid binaries, for improved security. See http://www.linuxfromscratch.org/~manuel/hlfs-book/glibc-2.4/chapter02/pie.html for more documentation on the topic.
Comment 1 Vincent Untz 2012-02-24 10:40:04 UTC 
Created attachment 208335 [details] [review]
gnome-pty-helper: Respect SUID_CFLAGS and SUID_LDFLAGS

This is a good way for distributors to use -fPIE/-pie when building vte.
Comment 2 Christian Persch 2012-02-24 10:57:43 UTC 
This is not completely correct; you need to add $(AM_CFLAGS) resp. $(AM_LDFLAGS) too. And shouldn't these variables be declared as precious in g-p-h's configure.in ?
Comment 3 Vincent Untz 2012-02-24 11:49:07 UTC 
Created attachment 208338 [details] [review]
gnome-pty-helper: Respect SUID_CFLAGS and SUID_LDFLAGS

Oh, good points. Updated patch should fix those issues.
Comment 4 Christian Persch 2012-02-24 12:41:13 UTC 
Thanks! Please commit to vte-0-32 and vte-next branches.
Comment 5 Vincent Untz 2012-02-24 12:51:10 UTC 
Comment on attachment 208338 [details] [review]
gnome-pty-helper: Respect SUID_CFLAGS and SUID_LDFLAGS

Pushed, thanks for the review!