After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670724 - gtk-doc.make: double recursion when maintainer-clean
gtk-doc.make: double recursion when maintainer-clean
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: 1.19
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-24 07:44 UTC by Daiki Ueno
Modified: 2012-02-25 17:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (594 bytes, patch)
2012-02-24 07:44 UTC, Daiki Ueno
committed Details | Review

Description Daiki Ueno 2012-02-24 07:44:03 UTC
Created attachment 208317 [details] [review]
patch

I get the following error when I make maintainer-clean in the fresh glib git working copy:

 Making maintainer-clean in gio
 make[3]: Entering directory `glib/docs/reference/gio'
 Making maintainer-clean in gdbus-object-manager-example
 make[4]: Entering directory `glib/docs/reference/gio/gdbus-object-manager-example'
 ...
 make[4]: Leaving directory `glib/docs/reference/gio/gdbus-object-manager-example'
 Making maintainer-clean in .
 make[4]: Entering directory `glib/docs/reference/gio'
 Making clean in gdbus-object-manager-example
 make[5]: Entering directory `glib/docs/reference/gio/gdbus-object-manager-example'
 make[5]: *** No rule to make target `clean'.  Stop.
 make[5]: Leaving directory `glib/docs/reference/gio/gdbus-object-manager-example'
 make[4]: *** [clean-recursive] Error 1

where docs/references/gio/Makefile.am has:

 SUBDIRS = gdbus-object-manager-example

Apparently, this is because gtk-doc.make has the following line:

 maintainer-clean-local: clean

Since the default "maintainer-clean" target is "maintainer-clean-recursive" and "clean" target is "clean-recursive", "maintainer-clean-local" depending on "clean" triggers double recursion.  I think it could be simply:

 maintainer-clean-local:
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2012-02-25 17:23:08 UTC
commit 8ac0de1a5298d4f48808d7d7275a20267488bffd
Author: Daiki Ueno <ueno@unixuser.org>
Date:   Fri Feb 24 16:23:31 2012 +0900

    make: avoid double recursion when make maintainer-clean.