GNOME Bugzilla – Bug 670719
Expose ATK_STATE_EXPANDABLE and ATK_STATE_EXPANDED as appropriate for Alt+Tab switcher
Last modified: 2012-03-15 19:01:52 UTC
From the gnome-shell "Cheat Sheet": > Alt+Tab switches between applications. Window previews of the > applications with multiple windows are available as you cycle > through. The previews show up after a short delay, but you can > get them immediately by pressing the Down arrow key. The fact that there are multiple windows which can be selected is presented to sighted users via a downward-pointing triangle. [1] The presence of this triangle should be exposed non-visually so that screen reader users know when they have the option to Down Arrow. In chatting briefly with Piñeiro about this, exposing STATE_EXPANDABLE and STATE_EXPANDED seem like the most logical (and hopefully a relatively easy?) way to accomplish this. [1] See https://live.gnome.org/GnomeShell/CheatSheet action=AttachFile&do=get&target=shortcuts-Alt-Tab.png
A JFYI comment. While working on this I discovered something. If you are focused on one alt+tab switcher icon without the arrow, you still can press down and the thumbnail window appears. Yes, I didn't know it, I always thought that this would only work on icons with the arrow. In theory that would mean that we could use EXPANDABLE for each icon on the alt+tab switcher.t Anyway, the purpose of this bug is expose to the user that the icon could be worth to be expanded. So in the same way that the shell is showing to the user that arrow in the icons with more of one thumbnail, as a hint that it is worth to be expanded, although in fact, icons without the arrow are also expandable, I plan to do the same with the atk state.
Created attachment 209246 [details] [review] Add EXPANDABLE and EXPANDED state on Alt+Tab popup items
Comment on attachment 209246 [details] [review] Add EXPANDABLE and EXPANDED state on Alt+Tab popup items You should just set EXPANDABLE on each relevant item from AppSwitcher._addIcon() rather than waiting until highlight() to do it.
Created attachment 209506 [details] [review] Add EXPANDABLE and EXPANDED state on Alt+Tab popup items (In reply to comment #3) > (From update of attachment 209246 [details] [review]) > You should just set EXPANDABLE on each relevant item from > AppSwitcher._addIcon() rather than waiting until highlight() to do it. Done. Anyway this patch assumes that appIcon.cachedWindows.length is "== 1" or "> 1" Just in case I will upload an alternative patch.
Created attachment 209507 [details] [review] Alternative patch This patch adds a extra if, instead of use the already existing one like previous patch.
BTW, although totally offtopic: AppSwitcher._addIcon has this line: let n = this._arrows.length; But n is not used on this function.
Comment on attachment 209506 [details] [review] Add EXPANDABLE and EXPANDED state on Alt+Tab popup items cachedWindows.length can never be < 1, so you don't need the extra check