After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670680 - "make check" assumes gdk backend will be built
"make check" assumes gdk backend will be built
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
1.9.x
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-23 13:02 UTC by Vincent Untz
Modified: 2012-02-23 17:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Make abicheck.sh backend-aware (2.28 KB, patch)
2012-02-23 14:36 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Vincent Untz 2012-02-23 13:02:15 UTC 
I just started building clutter 1.9.12 for openSUSE and it fails with:

+ make -j4 check
Making check in clutter
make[1]: Entering directory `/home/abuild/rpmbuild/BUILD/clutter-1.9.12/clutter'
make  check-am
make[2]: Entering directory `/home/abuild/rpmbuild/BUILD/clutter-1.9.12/clutter'
make  check-TESTS
make[3]: Entering directory `/home/abuild/rpmbuild/BUILD/clutter-1.9.12/clutter'
--- expected-abi        2012-02-23 12:58:33.772000001 +0000
+++ actual-abi  2012-02-23 12:58:33.780000001 +0000
@@ -638,13 +638,6 @@
 clutter_font_flags_get_type
 clutter_frame_source_add
 clutter_frame_source_add_full
-clutter_gdk_disable_event_retrieval
-clutter_gdk_get_default_display
-clutter_gdk_get_stage_from_window
-clutter_gdk_get_stage_window
-clutter_gdk_handle_event
-clutter_gdk_set_display
-clutter_gdk_set_stage_foreign
 clutter_geometry_get_type
 clutter_geometry_intersects
 clutter_geometry_union
FAIL: abicheck.sh
========================================================================
1 of 1 test failed
Please report to http://bugzilla.gnome.org/enter_bug.cgi?product=clutter
========================================================================
make[3]: *** [check-TESTS] Error 1
make[3]: Leaving directory `/home/abuild/rpmbuild/BUILD/clutter-1.9.12/clutter'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/clutter-1.9.12/clutter'
make[1]: *** [check] Error 2
make[1]: Leaving directory `/home/abuild/rpmbuild/BUILD/clutter-1.9.12/clutter'
make: *** [check-recursive] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.7TDyPo (%check)
Comment 1 Vincent Untz 2012-02-23 13:09:19 UTC 
So it turns out we are not building the gdk backend in our package; I can fix this. But it sounds wrong to have "make check" assume the gdk backend will be built.
Comment 2 Emmanuele Bassi (:ebassi) 2012-02-23 14:25:42 UTC 
on Linux, which is the only platform on which I do the ABI check, I always assume the x11 and gdk backends are there; in the future, I may even add Wayland, and even the EGL-based ones.

I'd accept a patch to abicheck.sh that only included the backends that were actually built; we already have a TESTS_ENVIRONMENT target that can be used to manipulate the environment of the abicheck.sh, so it could be possible to use that.
Comment 3 Emmanuele Bassi (:ebassi) 2012-02-23 14:36:21 UTC 
Created attachment 208268 [details] [review]
build: Make abicheck.sh backend-aware

Turns out, it was easier than I thought.
Comment 4 Emmanuele Bassi (:ebassi) 2012-02-23 17:32:46 UTC 
Attachment 208268 [details] pushed as f27e575 - build: Make abicheck.sh backend-aware