After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670678 - User docs mention "Scientific mode"
User docs mention "Scientific mode"
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: docs
6.3.x
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-23 12:27 UTC by André Klapper
Modified: 2012-03-28 00:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Mention of scientific mode removed and advanced mode description fixed (956 bytes, text/plain)
2012-03-25 22:32 UTC, Gopal Krishnan
  Details
Patched mouse and trignometry (1.49 KB, patch)
2012-03-27 16:21 UTC, Gopal Krishnan
needs-work Details | Review
Fixed the trignometry link (773 bytes, patch)
2012-03-27 16:40 UTC, Gopal Krishnan
reviewed Details | Review

Description André Klapper 2012-02-23 12:27:08 UTC
The following help pages mention the "scientific" mode:
trigonometry.page
number-display.page
mouse.page
scientific.page

6.3.5 does not provide that mode anymore, looks like it was merged into Advanced mode (though I cannot find a git commit for that)?
Comment 1 André Klapper 2012-03-22 10:17:37 UTC
If a maintainer answered my question I could even fix this. :P
Comment 2 Robert Ancell 2012-03-22 23:21:52 UTC
Yes, scientific mode was merged into advanced mode in 5.31.1, please fix :)

http://git.gnome.org/browse/gcalctool/commit/?id=6a2897ea1b6f899922a0d4acaa112cada99a7f89
Comment 3 Gopal Krishnan 2012-03-25 22:22:14 UTC
I have edited the documents however I am not sure of how to create a patch file and upload it. If someone can guide me that would be great!

Gopal
Comment 4 Gopal Krishnan 2012-03-25 22:32:31 UTC
Created attachment 210596 [details]
Mention of scientific mode removed and advanced mode description fixed

Removed scientific mode and added the trigonometric page link into advanced mode by saying: "such as trigonometric" after advanced mathematics.
Comment 5 Gopal Krishnan 2012-03-25 22:33:48 UTC
^ edited mouse.page and removed mentions of scientific. Also no other mentions of scientific mode was seen. The others pages mentioned link to scientific notation which still exists. Also I could not make this into a patch so if someone could convert into one or help me that would be great
Comment 6 André Klapper 2012-03-27 14:55:17 UTC
Hi Gopal, thanks for the file! 
It seems to be a new version of mouse.page. 
However we need this as a patch (a file that shows the differences) and we must update all the four files that I listed in comment 0 - see https://live.gnome.org/Git/Developers#Contributing_patches
Comment 7 André Klapper 2012-03-27 15:00:10 UTC
Ooops, sorry, I didn't read comment 5. I see... so please ignore most of my last comment, but we still need a patch, preferably with "git format-patch". :)
Comment 8 Gopal Krishnan 2012-03-27 15:56:54 UTC
^Oh okay, well I am trying to figure that part out. Once I do get that I will submit it. In the meantime the edited mouse page I attached it...
Comment 9 Gopal Krishnan 2012-03-27 16:21:43 UTC
Created attachment 210712 [details] [review]
Patched mouse and trignometry

Final Patch file that has patched trignometry and mouse pages.
Comment 10 André Klapper 2012-03-27 16:29:24 UTC
Review of attachment 210712 [details] [review]:

Great, thanks for the git formatted patch!

::: help/C/mouse.page
@@ +20,3 @@
     <tr>
     <td><p>Advanced</p></td>
+    <td><p>Provides buttons suitable for advanced mathematics such as <link xref="trigonometry"></p></td>

<link> is missing the closing tag. You can test this yourself for example by running "yelp ." (with space and dot) in the subfolder /help/C/ in your checkout of gcalctool.
Comment 11 Gopal Krishnan 2012-03-27 16:40:55 UTC
Created attachment 210714 [details] [review]
Fixed the trignometry link

Fixed trigonometry link. I do not know how to rebase yet since I am knew to patching so I uploaded the trigonometry link fix as a second patch file.
Comment 12 Gopal Krishnan 2012-03-27 16:41:27 UTC
^Thanks for pointing it out Andre. Still knew here..
Comment 13 Tiffany Antopolski 2012-03-28 00:20:50 UTC
Review of attachment 210714 [details] [review]:

This works.
Comment 14 Tiffany Antopolski 2012-03-28 00:22:52 UTC
Hi Gopal, 

  I took both your commits, squashed them into one, and pushed them to the master branch.

http://git.gnome.org/browse/gcalctool/commit/?id=ddf2d4ad74e2b153ebed6310f071e3f306c1fefe

Thanks for the fix!
Comment 15 Gopal Krishnan 2012-03-28 00:23:27 UTC
^Ooh Thanks Tiffany for confirming that!