After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670654 - Possible dereference through a stale pointer
Possible dereference through a stale pointer
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-23 01:38 UTC by Jason Gerecke
Modified: 2012-02-23 09:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wacom: Unref only when done with variables (1.66 KB, patch)
2012-02-23 01:38 UTC, Jason Gerecke 		committed Details | Review

Description Jason Gerecke 2012-02-23 01:38:54 UTC 
The "cursor" device for my Graphire4 was not moving the mouse cursor
on screen. On further inspection, the cause was narrowed down to
bogus values for the 'Wacom Tablet Area' property. git-bisect shows
commit 152a5c43 responsible.

It appears that we're calling g_variant_unref too early, leading to
memory being re-used for other purposes before the call out to the
driver finishes.
Comment 1 Jason Gerecke 2012-02-23 01:38:57 UTC 
Created attachment 208225 [details] [review]
wacom: Unref only when done with variables

The GVariants provided to set_area and set_presssurecurve are
unref-ed before the final use of the reference.
Comment 2 Bastien Nocera 2012-02-23 09:58:49 UTC 
Attachment 208225 [details] pushed as e1ae588 - wacom: Unref only when done with variables