GNOME Bugzilla – Bug 670638
3.3.90 still includes farsight headers
Last modified: 2012-02-23 08:39:19 UTC
While building empathy 3.3.90 (in a chroot), I observer that there are still references to farsight include headers. configure.ac dropped all the checks for farsight and switched entirely to farstream. Build failure (without farsight available): In file included from empathy-call-factory.c:36:0: empathy-call-handler.h:27:46: fatal error: gst/farsight/fs-conference-iface.h: No such file or directory compilation terminated. make[2]: *** [empathy_call-empathy-call-factory.o] Error 1 make[2]: *** Waiting for unfinished jobs.... In file included from empathy-call-handler.c:36:0: empathy-call-handler.h:27:46: fatal error: gst/farsight/fs-conference-iface.h: No such file or directory compilation terminated. make[2]: *** [empathy_call-empathy-call-handler.o] Error 1 In file included from empathy-call-window.h:27:0, from empathy-call.c:43: empathy-call-handler.h:27:46: fatal error: gst/farsight/fs-conference-iface.h: No such file or directory compilation terminated. make[2]: *** [empathy_call-empathy-call.o] Error 1 In file included from empathy-call-window.h:27:0, from empathy-call-window-fullscreen.h:26, from empathy-call-window-fullscreen.c:25: empathy-call-handler.h:27:46: fatal error: gst/farsight/fs-conference-iface.h: No such file or directory compilation terminated. make[2]: *** [empathy_call-empathy-call-window-fullscreen.o] Error 1 empathy-call-window.c:41:52: fatal error: gst/farsight/fs-element-added-notifier.h: No such file or directory compilation terminated. make[2]: *** [empathy_call-empathy-call-window.o] Error 1 make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/empathy-3.3.90/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/abuild/rpmbuild/BUILD/empathy-3.3.90' make: *** [all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.xl6a0e (%build) ==== A grep over the 3.3.90 source shows four references to farsight headers: empathy-3.3.90> grep "#include.*farsight" * -r src/empathy-video-widget.c:#include <gst/farsight/fs-element-added-notifier.h> src/empathy-call-handler.h:#include <gst/farsight/fs-conference-iface.h> src/empathy-call-window.c:#include <gst/farsight/fs-element-added-notifier.h> src/empathy-call-window.c:#include <gst/farsight/fs-utils.h>
Created attachment 208220 [details] [review] Patch that fixes this This patch should do the trick, at least it did for me.
(In reply to comment #1) > Created an attachment (id=208220) [details] [review] > Patch that fixes this > > This patch should do the trick, at least it did for me. Thanks... That seems indeed really to be all that's needed... I should have read up on the fact that farstream is fully API compatible.
Review of attachment 208220 [details] [review]: It's not fully API compatible.. but this bit is.
Thanks for the patch!