GNOME Bugzilla – Bug 670602
libsoup2.4: Fix arguments for MessageHeaders.get_range
Last modified: 2012-02-24 09:09:55 UTC
There's still a slight problem with that, the libsoup docs say to free the returned array with soup_message_headers_free_ranges() so no idea if that's doable with annotations.
Created attachment 208192 [details] [review] libsoup2.4: Fix arguments for MessageHeaders.get_range
(In reply to comment #0) > There's still a slight problem with that, the libsoup docs say to free the > returned array with soup_message_headers_free_ranges() so no idea if that's > doable with annotations. Not possible. Anyway, free_ranges() will just g_free() so it's fine for now.
Review of attachment 208192 [details] [review]: The patch looks good, thanks. ::: vapi/metadata/Soup-2.4.metadata @@ +46,3 @@ .get_content_type.* out unowned=false .get_content_*.params type_arguments="string,string" + .get_ranges.ranges out type="Soup.Range[]" array_length_idx=2 You can use `array` instead of `type="Soup.Range[]"`, to mark the type as an array.
(In reply to comment #2) > (In reply to comment #0) > > There's still a slight problem with that, the libsoup docs say to free the > > returned array with soup_message_headers_free_ranges() so no idea if that's > > doable with annotations. > > Not possible. Anyway, free_ranges() will just g_free() so it's fine for now. Is it ok if I also hide the free_ranges() function then? It's kind of useless then.
(In reply to comment #5) > Is it ok if I also hide the free_ranges() function then? It's kind of useless > then. No it's ok as is. Feel free to push.
Attachment 208192 [details] pushed as 519a36c - libsoup2.4: Fix arguments for MessageHeaders.get_range