GNOME Bugzilla – Bug 670595
nautilus crashed with SIGSEGV in do_unmount()
Last modified: 2012-03-05 17:05:28 UTC
The bug got report against nautilus 3.3.90 on https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/937824 (but is not new to this version, we got earlier bug reports in the serie) "#0 do_unmount (data=0x1) at nautilus-file-operations.c:2071 mount_op = <optimized out>
+ Trace 229711
Created attachment 208521 [details] [review] Proposed patch This should fix the issue. do_unmount was being used as a done_callback for empty_trash_job, but didn't have the right prototype for that. As a result, it tried to interpret a gboolean as a pointer to a data structure. This patch puts the gboolean into the prototype to avoid the crash (though it doesn't do anything useful with that 'success' flag).
Review of attachment 208521 [details] [review]: Thanks Michael, looks good!
Pushed this to master now.