After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670397 - Building of sound-juicer 3.3.90 fails
Building of sound-juicer 3.3.90 fails
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
git master
Other Linux
: Normal critical
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-19 15:02 UTC by Dominique Leuenberger
Modified: 2012-02-27 19:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix this (1.45 KB, patch)
2012-02-19 17:00 UTC, Christophe Fergeau
committed Details | Review

Description Dominique Leuenberger 2012-02-19 15:02:32 UTC
The error was introduced with this commit:
http://git.gnome.org/browse/sound-juicer/commit/configure.in?id=265a47a6fb58da2a0358ccbb981f0424993643ee

Sound-Juicer was ported away from dbus-glib, but the tests folder was not updated accordingly. As a result, building the tests fails with:

gcc -DHAVE_CONFIG_H -I. -I..  -I../libjuicer -I../src -DGNOMELOCALEDIR=\""/usr/share/locale"\"    -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare  -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2   -pthread -I/usr/include/brasero3 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/gio-unix-2.0/ -I/usr/include/pixman-1 -I/usr/include/libpng14   -pthread -D_REENTRANT -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gio-unix-2.0/ -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/gconf/2 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include     -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -c -o mb_test-mb-test.o `test -f 'mb-test.c' || echo './'`mb-test.c
mb-test.c: In function 'main':
mb-test.c:104:3: warning: 'g_thread_init' is deprecated (declared at /usr/include/glib-2.0/glib/deprecated/gthread.h:259) [-Wdeprecated-declarations]
  CCLD   mb-test
/usr/lib64/gcc/x86_64-suse-linux/4.6/../../../../x86_64-suse-linux/bin/ld: mb_test-mb-test.o: undefined reference to symbol 'dbus_threads_init_default'
/usr/lib64/gcc/x86_64-suse-linux/4.6/../../../../x86_64-suse-linux/bin/ld: note: 'dbus_threads_init_default' is defined in DSO /lib64/libdbus-1.so.3 so try adding it to the linker command line
/lib64/libdbus-1.so.3: could not read symbols: Invalid operation
collect2: ld returned 1 exit status
make[2]: *** [mb-test] Error 1
make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/sound-juicer-3.3.90/tests'

(DBUS_LIBS obviously is now empty on Makefile of tests and thus linking libdbus-1.so.3 is not done.)
Comment 1 Christophe Fergeau 2012-02-19 17:00:17 UTC
Created attachment 207997 [details] [review]
Patch to fix this

I have this patch locally, I thought I had pushed it already
Comment 2 Ross Burton 2012-02-19 20:49:47 UTC
I wonder why this continues to build for me... something must be bring in dbus. Anyway, pushed.
Comment 3 Dominique Leuenberger 2012-02-27 19:43:34 UTC
(In reply to comment #2)
> I wonder why this continues to build for me... something must be bring in dbus.
> Anyway, pushed.

This is probably because in openSUSE we have --copy-dt-needed-entries as default linker flag enabled.