Created attachment 207973 [details] [review]
Use AccountsService to retrieve avatar

Review of attachment 207973 [details] [review]:

Looks good. Please rebase on master so I can test it before saying ACK. Also please don't forget to push the vapi to vala as well, if not done already.

Created attachment 207993 [details] [review]
Use AccountsService to retrieve avatar

This is the method used by GNOME Shell. The previous method is not so
reliable.

I try to push the binding in upstream first, filed a bug earlier today. If they refuse it, I'll propose it in vala.

Created attachment 207995 [details] [review]
Use AccountsService to retrieve avatar

This is the method used by GNOME Shell. The previous method is not so
reliable.

Created attachment 208354 [details] [review]
Use fdo.Accounts service to retrive avatar

We use avatar-default when setting up the UI, then we query Accounts
and replace it.  I couldn't find how the unattended installer was
making use of it. Perhaps it's something still on the todo list

Review of attachment 208354 [details] [review]:

Looks good otherwse, i'll test and then ack :)

::: src/unattended-installer.vala
@@ -175,0 +175,11 @@
+        avatar.show_all ();
+
+        accounts.FindUserByName.begin (Environment.get_user_name (), (obj, result) => {
... 8 more ...

I'd prefer providing some context to log output: warning ("Failed to fetch user information: %s", error.message);

Created attachment 208374 [details] [review]
Use fdo.Accounts service to retrive avatar

We use avatar-default when setting up the UI, then we query Accounts
and replace it.  I couldn't find how the unattended installer was
making use of it. Perhaps it's something still on the todo list

Reviewed and modified by Zeeshan Ali (Khattak) <zeeshanak@gnome.org>.

So I rebased, tested and then modified your last patch. Let me know what you think of it.

Review of attachment 208374 [details] [review]:

ack

Comment on attachment 208374 [details] [review]
Use fdo.Accounts service to retrive avatar

Attachment 208374 [details] pushed as d304b1c - Use fdo.Accounts service to retrive avatar

fixed in git