GNOME Bugzilla – Bug 670379
Add WebP image loader module
Last modified: 2021-04-05 07:14:38 UTC
Created attachment 207962 [details] [review] io-webp.c & build file updates Attached is a patch adding support for the WebP image format (http://code.google.com/speed/webp/) to gdk-pixbuf. I appreciate any feedback and interest.
Version 0.2 Released few days ago. https://code.google.com/p/webp/downloads/list The maturity of this open-source image codec deserve priority. Also wish to advice that Opera and Chrome already support it but there is no Image-viewer in Linux that support it. Too many people will be happy to see this upgrade. Many thanks !
we generally prefer loaders to be shipped with the library they are using, nowaday.
I really have no idea how it works, but will be helpful to be able to see WebP images in gnome Image Viewer. Is this a bug relatin to Image Viewer ?
It has been some time. I wonder if the next release of GNOME (3.10) will be support for WebP (especially image viewer and browser). It's a format that shows promise (albeit forcibly pushed by Google) and is open-source. thanks
As per comment 2, filed against the WebP library at: https://code.google.com/p/webp/issues/detail?id=227
Hello, is there still interest to work on this patch? WebP has become quite wide-spread since ... 2012! Are the maintainer listed on this bug still active? If so, we (WebP) can probably start having a look at updating this initial io-webp.c patch... thanks! skal - for libwebp.
(In reply to pascal.massimino from comment #6) > Hello, > > is there still interest to work on this patch? WebP has become quite > wide-spread since ... 2012! It really hasn't quite to a degree where we might want to consider it for inclusion in gdk-pixbuf. Browsers do not use gdk-pixbuf to open images, and as for its use in other formats (I know of web comics being packaged with webp images) applications can embed their own plugins (GIMP, and other image manipulation software would do that), or a copy of the out-of-tree webp gdk-pixbuf loader (as evince does to load those aforementioned comics). I still don't think we want a webp loader in gdk-pixbuf, but having one integrated into libwebp's source tree would definitely be useful to those applications that want to use it. > Are the maintainer listed on this bug still active? If so, we (WebP) can > probably start having a look at updating this initial io-webp.c patch...
"or a copy of the out-of-tree webp gdk-pixbuf loader (as evince does" ...maybe that's a sign it's time to be merged in?
(In reply to dfhyuilkiolioup from comment #8) > "or a copy of the out-of-tree webp gdk-pixbuf loader (as evince does" > ...maybe that's a sign it's time to be merged in? Why? What would be gained by having an in-tree loader, outside of potential new CVEs and additional maintenance burden, for a format that is not used for icons? GdkPixbuf allows out of tree loaders explicitly to allow people to write loaders as part of their image loading libraries. The in-tree loaders are the minimum required to load icons and other graphical assets shipped by applications themselves (and not even all of them; SVG assets require a loader shipped by librsvg). If anything, GdkPixbuf's scope has been reduced over the years, to cope with the reduced maintenance resources available; adding new in-tree loaders would go against that.
Hi, for what is worth, on the libwebp side, gdk-pixbuf name surfaced in this bug: https://bugs.chromium.org/p/webp/issues/detail?id=401#c6 where it was mentioned that EOG was using it. Supporting gdk-pixbuf loader directly within libwebp is outside of the intended initial scope (few users would know how to use that code, i fear). skal/ (and yes, webp is actually used quite a lot for icons and game assets, because of its lossy+lossless-alpha feature, as a smaller replacement for PNGs)
I came from https://gitlab.gnome.org/GNOME/gdk-pixbuf/issues/103 (I presume then that bugzilla is still the right place for bugs in the case of gdk?) while about to file the same kind of feature request, thinking it would be the place to file it instead of in Nautilus, in EOG, in... So please pardon my potentially foolish question here as a simple user trying to understand the situation: how/where do we get support for viewing and thumbnailing images in the GNOME desktop, so that when we save a webp photo (for example) from a website, or are working with such assets (ex: a web designer creating WebP images with GIMP) we can see them appropriately thumbnailed in Nautilus and openable with standard image viewers? (and iff gdk is not the right place, where do we refile this?)
Please, use GitLab for GdkPixbuf issues. Bugzilla has been closed. > (I presume then that bugzilla is still the right place for bugs in the case of gdk?) GdkPixbuf has nothing to do with GDK; and, no: Bugzilla is not the right place for bugs for either GdkPixbuf or GDK. > how/where do we get support for viewing and thumbnailing images in the > GNOME desktop, so that when we save a webp photo (for example) from a > website, or are working with such assets (ex: a web designer creating WebP > images with GIMP) we can see them appropriately thumbnailed in Nautilus and > openable with standard image viewers? You will need to create a GdkPixbuf loader module that knows how to load webp images (whether it's part of libwebp or a stand alone project doesn't really matter); then the gdk-pixbuf-based thumbnailer will be able to generate thumbnails of webp images. This is similar to how SVG images are handled; GdkPixbuf does not support SVG image loading out of the box, but librsvg provides a GdkPixbuf loader module.