GNOME Bugzilla – Bug 670372
Annotate var-arg gdk_pixbuf_save*() as aliases for save*v()
Last modified: 2018-05-22 13:13:13 UTC
Created attachment 207956 [details] [review] Annotate var-arg gdk_pixbuf_save*() as aliases for save*v() This patch the various vector variants so that they shadow the var-arg variants.
Ping.
Created attachment 289066 [details] [review] lib: Annotate var-arg gdk_pixbuf_save*() Annotate var-args gdk_pixbuf_save*() functions as aliases for save*v() so that the functions shadow the var-arg variants.
Attachment 289066 [details] pushed as 112eab4 - lib: Annotate var-arg gdk_pixbuf_save*()
Fyi, this removed GdkPixbuf.Pixbuf.savev in Python breaks API.
Yes, the old savev API was accessible via introspection, so this is an IABI break.
The cleanest might be to add (rename-to-and-keep) to introspection. I thought we did that by default actually, in the .gir it still exists, just sets shadows=. Did this change make it into a stable gdk-pixbuf release? If so things get messy. If not the simplest might be to revert, since we know this breaks at least two apps, and figure out a better way to make this change?
This makes downstream apps use workarounds like https://git.gnome.org/browse/gnome-continuous/commit/?id=582e0aedd909cc59ae66474ae11077455bb41cbe
(In reply to comment #6) > The cleanest might be to add (rename-to-and-keep) to introspection. I thought > we did that by default actually, in the .gir it still exists, just sets > shadows=. > > Did this change make it into a stable gdk-pixbuf release? If so things get > messy. If not the simplest might be to revert, since we know this breaks at > least two apps, and figure out a better way to make this change? It's only in gdk-pixbuf devel, not in any stable releases.
should we do as suggested in comment 6 then, and revert ?
(In reply to Colin Walters from comment #6) > The cleanest might be to add (rename-to-and-keep) to introspection. Think that might also be a possible way to fix bug #660923
Breaking MyPaint (Python): https://github.com/mypaint/mypaint/issues/236 - crosscuts with an attempted workaround for POSIX/Windows API inconsistencies too, for extra confusion amongst us poor devs.
Reverted in master. If and when we break API/ABI, we should reapply this.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gdk-pixbuf/issues/32.