After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670369 - gdk: annotate the attributes_mask type for gdk_window_new
gdk: annotate the attributes_mask type for gdk_window_new
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 672338 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-02-18 19:22 UTC by Torsten Schoenfeld
Modified: 2012-06-11 20:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdk: annotate the attributes_mask type for gdk_window_new (1.07 KB, patch)
2012-02-18 19:22 UTC, Torsten Schoenfeld 		committed Details | Review

Description Torsten Schoenfeld 2012-02-18 19:22:14 UTC 
This patch adds a type annotation for attributes_mask to gdk_window_new.  If
there is no reason for the C declaration to use gint here, then we could also
just change the declaration itself.
Comment 1 Torsten Schoenfeld 2012-02-18 19:22:16 UTC 
Created attachment 207952 [details] [review]
gdk: annotate the attributes_mask type for gdk_window_new
Comment 2 Torsten Schoenfeld 2012-03-18 12:15:32 UTC 
*** Bug 672338 has been marked as a duplicate of this bug. ***
Comment 3 Torsten Schoenfeld 2012-06-10 20:26:09 UTC 
Ping.
Comment 4 Matthias Clasen 2012-06-10 23:30:39 UTC 
Review of attachment 207952 [details] [review]:

Sure, looks ok. I can't imagine this being a very nice function to use from bindings, though
Comment 5 Torsten Schoenfeld 2012-06-11 20:35:15 UTC 
Attachment 207952 [details] pushed as 61972a3 - gdk: annotate the attributes_mask type for gdk_window_new
Comment 6 Torsten Schoenfeld 2012-06-11 20:37:50 UTC 
Thanks for the review.

(In reply to comment #4)
> I can't imagine this being a very nice function to use from
> bindings, though

We determine the mask automatically if the user does not provide one, and then it's OK to use:

  Gtk3::Gdk::Window->new ($parent, {
    window_type => 'toplevel',
    width => 100, height => 50,
    x => 100, y => 50,
  })