GNOME Bugzilla – Bug 670349
jhbuild: fix handling of pretty_print=False
Last modified: 2012-02-22 16:32:15 UTC
Created attachment 207923 [details] [review] fix handling of pretty_print=False Manuals advises to set pretty_print=False "if the pretty printing causes problems". It causes problems on Windows (select.select() raises exception), but disabling pretty_print doesn't help. I looked into history in git and I suppose it was broken in 2295743a12375210a3e1effecaac76248e9a293b when quiet mode was introduced. It's not clear to me why that commit changed handling pretty_print ("hint=None" line was moved.) I'm attaching a patch that fixes this issue by reverting a part of mentioned commit, and another patch that hints user to disable pretty-printing when select.error exception is thrown.
Created attachment 207924 [details] [review] hint user to disable pretty-printing when select.error exception is thrown
Can we: 1) Make pretty print work on windows 2) Default it to off Rather than throwing an error message at the user telling them to unbreak it?
(In reply to comment #2) > Can we: > > 1) Make pretty print work on windows > 2) Default it to off > > Rather than throwing an error message at the user telling them to unbreak it? Both sound good to me, but I don't volunteer for 1)
regardless what pretty_print defaults to, the first patch can be applied because now setting pretty_print=False doesn't prevent entering pprint_output() (and crashing on Windows).
(In reply to comment #4) > regardless what pretty_print defaults to, the first patch can be applied > because now setting pretty_print=False doesn't prevent entering pprint_output() > (and crashing on Windows). Ok, yes, I've committed that. But what do you think about the following patch?
Created attachment 208203 [details] [review] terminal: Disable pretty printing on Windows by default It doesn't work due to some select() failure, and honestly jhbuild's control of subprocesses and output is so totally broken I'd rather just band aid this and move on with my replacement project.
Looks good to me.
Attachment 208203 [details] pushed as 422588d - terminal: Disable pretty printing on Windows by default