After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670347 - Check for null birthday strings
Check for null birthday strings
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: Telepathy backend
git master
Other All
: Normal critical
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-18 14:09 UTC by Philip Withnall
Modified: 2012-03-19 18:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Handle null birthday strings (909 bytes, patch)
2012-02-18 14:10 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2012-02-18 14:09:53 UTC
It's possible for Telepathy to return null for birthdays in vCards. Folks currently doesn't handle this, and so the null will be passed straight through to g_timeval_from_iso8601(), which will crash.

Patch coming.
Comment 1 Philip Withnall 2012-02-18 14:10:49 UTC
Created attachment 207921 [details] [review]
Handle null birthday strings
Comment 2 Guillaume Desmottes 2012-03-19 14:22:18 UTC
Review of attachment 207921 [details] [review]:

++
Comment 3 Philip Withnall 2012-03-19 18:49:19 UTC
Comment on attachment 207921 [details] [review]
Handle null birthday strings

commit 01c0fd63a6371b804978fb3f523551114d4d06c1
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sat Feb 18 13:56:54 2012 +0000

    telepathy: Handle null birthday strings
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=670347

 NEWS                                    |    1 +
 backends/telepathy/lib/tpf-persona.vala |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)