After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670328 - Enable keyboard accelerator for the create-button on the Create-Web-Application-dialog
Enable keyboard accelerator for the create-button on the Create-Web-Applicati...
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
3.3.x
Other All
: Normal enhancement
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-18 03:58 UTC by Jiro Matsuzawa
Modified: 2012-03-04 23:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
a screenshot of the create-web-app dialog (12.33 KB, image/png)
2012-02-18 03:58 UTC, Jiro Matsuzawa
  Details
a patch for the bug (865 bytes, patch)
2012-02-18 04:17 UTC, Jiro Matsuzawa
accepted-commit_now Details | Review

Description Jiro Matsuzawa 2012-02-18 03:58:28 UTC
Created attachment 207910 [details]
a screenshot of the create-web-app dialog

The "Create" button on the Create-Web-Application-dialog do not have a keyboard accelerator.
Please refere to the attached screenshot of the dialog.

You should enable keyboard accelerator for the button.
I think it's useful if users can activate the create-button on a keyboard directly after typing the app name.

I'll attache a patch.
Comment 1 Jiro Matsuzawa 2012-02-18 04:17:49 UTC
Created attachment 207912 [details] [review]
a patch for the bug

I use 'r' of "Create" as a mnemonic character because "C" is already used by
"_Cancel".

Please review it.
Comment 2 Xan Lopez 2012-02-23 10:26:57 UTC
Review of attachment 207912 [details] [review]:

Thanks.
Comment 3 Jiro Matsuzawa 2012-03-04 23:19:35 UTC
I've pushed.
http://git.gnome.org/browse/epiphany/commit/?id=09b5484d8f321ad2f53bbc82f49233bfaac043e9

Thank you.