GNOME Bugzilla – Bug 670327
Orca doesn't present Categories on the Applications view correctly
Last modified: 2012-03-14 11:44:07 UTC
STEPS TO REPRODUCE 1. Orca running 2. Move to overview (Alt+F1) 3. Select Applications view (Ctrl+Alt+Tab) 4. Navigate to the categories at the right side 5. Navigate along the categories EXPECTED OUTCOME "All", "Accessories", "Games" etc ACTUAL OUTCOME "button" "button" "button" etc So: Name are not exposed, role is wrong
Created attachment 207908 [details] [review] Expose StButton:label as accessible name
Created attachment 207909 [details] [review] Setting MENU-ITEM role for the categories items In this case we have some StButton. Although in theory the role should be BUTTON, in this case I really think that are not behaving like that. After thinking a little I guess that the proper role is MENU_ITEM, as for the user that section seems a menu (anyway, with the same reasoning, this could be also a LIST_ITEM). So I'm changing the Button role to MENU_ITEM. I also changed the container for all those buttons to MENU (as having MENU_ITEM(s) without MENU sounds odd to me). Anyway, as I'm not 100%, CCing Joanmarie.
> In this case we have some StButton. Although in theory the role should be > BUTTON, in this case I really think that are not behaving like that. Agreed. > After > thinking a little I guess that the proper role is MENU_ITEM, as for the user > that section seems a menu (anyway, with the same reasoning, this could be also > a LIST_ITEM). Either of those seem reasonable, but.... I think what to me makes it more of a LIST_ITEM than a MENU_ITEM is how the user interacts with it. Normally when you activate a menu item and press Return, the menu is closed, focus moves, and the associated action gets performed. Here, nothing gets closed and focus doesn't move. > So I'm changing the Button role to MENU_ITEM. I also changed the > container for all those buttons to MENU (as having MENU_ITEM(s) without MENU > sounds odd to me). Agreed regarding the need to make an associated change in the container role. (So... presumably make it a LIST if you agree with my LIST_ITEM logic.)
Created attachment 207961 [details] [review] Setting LIST_ITEM role for categories Updated patch based on suggestion at comment 3
Created attachment 208057 [details] [review] Setting LIST_ITEM role for categories nitpick (just in case)
Comment on attachment 207908 [details] [review] Expose StButton:label as accessible name makes sense
Comment on attachment 208057 [details] [review] Setting LIST_ITEM role for categories yup
As first patch on bug 667432 was committed (that was the real dependency), and comment 6 and comment 7 didn't ask for further patch update, I have committed those patches. Closing as FIXED.