After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670314 - Don't prefix object name with target name because of VALAFLAGS
Don't prefix object name with target name because of VALAFLAGS
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: plugins: project-manager
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Naba Kumar
Anjuta maintainers
: 670313 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-02-17 18:07 UTC by Abderrahim Kitouni
Modified: 2012-02-22 20:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
am-project: don't prefix object name with target name because of VALAFLAGS (1.64 KB, patch)
2012-02-17 18:07 UTC, Abderrahim Kitouni 		accepted-commit_now Details | Review

Description Abderrahim Kitouni 2012-02-17 18:07:19 UTC 
Created attachment 207877 [details] [review]
am-project: don't prefix object name with target name because of VALAFLAGS

For some reason, automake doesn't add the target name as a prefix to object files if there is only VALAFLAGS.

Removing AM_PROPERTY_COMPILATION_FLAG fixes the issue, and it seems this is the only use for this, so here is a patch that does that.
Comment 1 Johannes Schmid 2012-02-18 08:55:06 UTC 
*** Bug 670313 has been marked as a duplicate of this bug. ***
Comment 2 Sébastien Granjoux 2012-02-20 20:09:52 UTC 
Just for confirmation, This is rather a bug in autotools, isn't it?

I think the .vala file is compiled and this is mandatory if you have two targets using the same source file but with different flags.

Else, the patch looks fine.
Comment 3 Abderrahim Kitouni 2012-02-21 20:43:19 UTC 
I don't, it's like this in automake and I don't want to think about it. Ultimately, the users are going to blame anjuta, but at the same time, if it ever gets fixed in automake, we'd be in the same situation again.

I'll let you decide what to do.
Comment 4 Sébastien Granjoux 2012-02-22 20:43:27 UTC 
Review of attachment 207877 [details] [review]:

Your patch is fine. I have committed it. If something change in autotools, we will try to find a solution. I have renamed the flag with a more explicit name because now it must be used only for this.