GNOME Bugzilla – Bug 670308
Orca doesn't present anything when run dialog is launched
Last modified: 2012-03-10 01:31:02 UTC
STEPS TO REPRODUCE 1. Launch Orca 1.1 Accessibility icon (top panel at the right) 1.2 Press Universal Access Settings 1.3 Screen Reader On 2. Press Alt+F2 3. Run dialog appear EXPECTED OUTCOME Orca presents "Please enter a command" (dialog label) and "text" (role of the entry focused). ACTUAL OUTCOME Nothing is presented. But Orca present each individual key event NOTES The reason of this problem was that StEntry were not exposing his internal ClutterText. There was also some issues with the order of the events, already fixed on clutter itself. Patches will arrive soon.
Created attachment 207872 [details] [review] a11y: accessible object for StEntry I only have a doubt for this patch, due the long names I used the following code style for the type-related macros: #define ST_ENTRY_ACCESSIBLE(obj) \ (G_TYPE_CHECK_INSTANCE_CAST ((obj), \ ST_TYPE_ENTRY_ACCESSIBLE, StEntryAccessible)) #define ST_IS_ENTRY_ACCESSIBLE(obj) \ (G_TYPE_CHECK_INSTANCE_TYPE ((obj), \ ST_TYPE_ENTRY_ACCESSIBLE)) #define ST_ENTRY_ACCESSIBLE_CLASS(klass) \ (G_TYPE_CHECK_CLASS_CAST ((klass), \ ST_TYPE_ENTRY_ACCESSIBLE, StEntryAccessibleClass)) #define ST_IS_ENTRY_ACCESSIBLE_CLASS(klass) \ (G_TYPE_CHECK_CLASS_TYPE ((klass), \ ST_TYPE_ENTRY_ACCESSIBLE)) #define ST_ENTRY_ACCESSIBLE_GET_CLASS(obj) \ (G_TYPE_INSTANCE_GET_CLASS ((obj), \ ST_TYPE_ENTRY_ACCESSIBLE, StEntryAccessibleClass)) I already used that style for StWidget. But on bug 668366 comment 3, Owen suggest that this style doesn't conform the used on other places. I used this style using as reference other classes like st-box-layout-child.h But is is true that other long-name-classed uses a one line style (like st-theme-node-transition.h, reaching a 139 line long) Which style should I use?
Created attachment 207873 [details] [review] a11y: setting role and label actor for run dialog
I forgot to mention: other example of requiring an accessible object for StEntry is the search entry at the overview.
Comment on attachment 207872 [details] [review] a11y: accessible object for StEntry code looks right. Just do what Owen says on the macro define style.
Comment on attachment 207873 [details] [review] a11y: setting role and label actor for run dialog looks good
Created attachment 208695 [details] [review] a11y: accessible object for StEntry (In reply to comment #4) > (From update of attachment 207872 [details] [review]) > code looks right. Just do what Owen says on the macro define style. I guess that this answer my question about if the correct style is the one used at st-theme-node-transition.h or the the one used at st-box-layout-child.h Updated patch, using the style at st-theme-node-transition.h Not committed yet as this bug depends on bug 667432.
(In reply to comment #6) > Not committed yet as this bug depends on bug 667432. Bug is not still fixed, but the patch related to this bug that allowed to set roles was committed, so the patches can be applied. Closing the bug as FIXED.