After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670256 - wizard: Add mnemonic accelerator to 'Continue' button
wizard: Add mnemonic accelerator to 'Continue' button
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-02-17 01:04 UTC by Zeeshan Ali
Modified: 2016-03-31 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wizard: Add mnemonic accelerator to 'Continue' button (1.24 KB, patch)
2012-02-17 01:04 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2012-02-17 01:04:34 UTC 
Add mnemonic accelerator for 'Continue' and 'Create'.
Comment 1 Zeeshan Ali 2012-02-17 01:04:37 UTC 
Created attachment 207825 [details] [review]
wizard: Add mnemonic accelerator to 'Continue' button
Comment 2 Marc-Andre Lureau 2012-02-17 09:22:24 UTC 
Review of attachment 207825 [details] [review]:

::: src/wizard.vala
@@ +99,2 @@
             back_button.sensitive = page != WizardPage.INTRODUCTION;
+            next_button.label = page != WizardPage.REVIEW ? _("C_ontinue") : _("C_reate");

does it work? (clutter doesn't eat the key?)

Is _C bad in this case? (since it's "Continue" OR "Create")
Comment 3 Zeeshan Ali 2012-02-17 14:44:30 UTC 
(In reply to comment #2)
> Review of attachment 207825 [details] [review]:
> 
> ::: src/wizard.vala
> @@ +99,2 @@
>              back_button.sensitive = page != WizardPage.INTRODUCTION;
> +            next_button.label = page != WizardPage.REVIEW ? _("C_ontinue") :
> _("C_reate");
> 
> does it work? (clutter doesn't eat the key?)

Yes, it works!

> Is _C bad in this case? (since it's "Continue" OR "Create")

_C would be my first choice too of course but its already taken by 'Cancel'.
Comment 4 Marc-Andre Lureau 2012-02-17 15:02:33 UTC 
Review of attachment 207825 [details] [review]:

ack
Comment 5 Zeeshan Ali 2012-02-17 15:16:22 UTC 
Attachment 207825 [details] pushed as 53eb3d5 - wizard: Add mnemonic accelerator to 'Continue' button