After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670244 - daemon: Make libgsd-profile.so and libgsd-session.so private shared libraries
daemon: Make libgsd-profile.so and libgsd-session.so private shared libraries
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-16 20:13 UTC by Colin Walters
Modified: 2012-02-18 16:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
daemon: Make libgsd-profile.so and libgsd-session.so private shared libraries (1.10 KB, patch)
2012-02-16 20:13 UTC, Colin Walters 		needs-work Details | Review
Unify libgsd-profile and libgsd-session into installed shared library (6.17 KB, patch)
2012-02-17 16:58 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2012-02-16 20:13:41 UTC 
Currently plugins can call back into the main binary; if the program
is linked with -Bsymbolic then what happens is the plugin process will
contain duplicate functions from the libgsd-session.la.

Ubuntu has patched their toolchain to link with -Bsymbolic-functions
by default which causes a failure here.

This is also just conceptually cleaner.
Comment 1 Colin Walters 2012-02-16 20:13:43 UTC 
Created attachment 207804 [details] [review]
daemon: Make libgsd-profile.so and libgsd-session.so private shared libraries
Comment 2 Sebastien Bacher 2012-02-16 20:25:15 UTC 
Confirmed, that patch fixes the issue we had when building with -Bsymbolic-functions
Comment 3 Bastien Nocera 2012-02-17 10:37:08 UTC 
Review of attachment 207804 [details] [review]:

I don't see the point in them being separate libraries. Please make them a single library, with a name that doesn't infer anything as to their contents.
Comment 4 Colin Walters 2012-02-17 16:58:52 UTC 
Created attachment 207868 [details] [review]
Unify libgsd-profile and libgsd-session into installed shared library

Currently plugins can call back into the main binary; if the program
is linked with -Bsymbolic then what happens is the plugin process will
contain duplicate functions from libgsd-session.la.

Ubuntu has patched their toolchain to link with -Bsymbolic-functions
by default which causes a failure here.

This is also just cleaner and better; there's only one copy of the
code on disk.
Comment 5 Bastien Nocera 2012-02-17 17:13:55 UTC 
Review of attachment 207868 [details] [review]:

Looking good.
Comment 6 Colin Walters 2012-02-18 16:37:39 UTC 
Attachment 207868 [details] pushed as 6cfa8ef - Unify libgsd-profile and libgsd-session into installed shared library