Created attachment 207799 [details] [review]
installer: Launch new domains in fullscreen

Review of attachment 207799 [details] [review]:

I am not sure it is such a good idea, get an ack from jimmac or mccann.

For example, if it's an installer, I don't really want to see it until it's ready.

(In reply to comment #2)
> Review of attachment 207799 [details] [review]:
> 
> I am not sure it is such a good idea, get an ack from jimmac or mccann.
> 
> For example, if it's an installer, I don't really want to see it until it's
> ready.

For unattended installs, yeah I think that is what a user wants but for other cases (where user will definitely have/want to interact with the guest soon), I think it is? Shall a modify the patch to not do this for unattended?

Alternatively, we should somehow signify (blink maybe?) the newly created box.

Going fullscreen makes sense for me, after special casing the auto install as you mention. It's critical we communicate how to exist fullscreen/stop capturing input though.

Created attachment 207938 [details] [review]
installer: Launch new domains in fullscreen

For non-express installations, after successfully creating and launching
a domain, select it and make it fullcreen.

Review of attachment 207938 [details] [review]:

::: src/vm-creator.vala
@@ +55,2 @@
         var domain = connection.create_domain (config);
+        ulong signal_id = 0;

this signal should be disconnected if some other item got selected before. Ghash, async is nice, but so full of potential races..

Created attachment 207944 [details] [review]
installer: Launch new domains in fullscreen

For non-express installations, after successfully creating and launching
a domain, select it and make it fullcreen.

Review of attachment 207944 [details] [review]:

ack

Attachment 207944 [details] pushed as ae25ec3 - installer: Launch new domains in fullscreen